-
Notifications
You must be signed in to change notification settings - Fork 14.6k
[clang] CWG150: add tests and change to unreleased #93758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) ChangesFull diff: https://github.com/llvm/llvm-project/pull/93758.diff 2 Files Affected:
diff --git a/clang/test/CXX/drs/cwg1xx.cpp b/clang/test/CXX/drs/cwg1xx.cpp
index 6bc63760f8333..6016af67aae1a 100644
--- a/clang/test/CXX/drs/cwg1xx.cpp
+++ b/clang/test/CXX/drs/cwg1xx.cpp
@@ -753,6 +753,46 @@ namespace cwg148 { // cwg148: yes
// cwg149: na
+namespace cwg150 { // cwg150: yes
+ namespace p1 {
+ template <class T, class U = int>
+ class ARG { };
+
+ template <class X, template <class Y> class PARM>
+ void f(PARM<X>) { }
+
+ void g() {
+ ARG<int> x;
+ f(x);
+ }
+ } // namespace p1
+
+ namespace p2 {
+ template <template <class T, class U = int> class PARM>
+ class C {
+ PARM<int> pi;
+ };
+ } // namespace p2
+
+ namespace n1 {
+ struct Dense { static const unsigned int dim = 1; };
+
+ template <template <typename> class View,
+ typename Block>
+ void operator+(float, View<Block> const&);
+
+ template <typename Block,
+ unsigned int Dim = Block::dim>
+ class Lvalue_proxy { operator float() const; };
+
+ void test_1d (void) {
+ Lvalue_proxy<Dense> p;
+ float b;
+ b + p;
+ }
+ } // namespace n1
+}
+
namespace cwg151 { // cwg151: 3.1
struct X {};
typedef int X::*p;
diff --git a/clang/www/cxx_dr_status.html b/clang/www/cxx_dr_status.html
index 4cce88fe0490f..628ee12992e6b 100755
--- a/clang/www/cxx_dr_status.html
+++ b/clang/www/cxx_dr_status.html
@@ -938,7 +938,7 @@ <h2 id="cxxdr">C++ defect report implementation status</h2>
<td><a href="https://cplusplus.github.io/CWG/issues/150.html">150</a></td>
<td>C++17</td>
<td>Template template parameters and default arguments</td>
- <td class="unknown" align="center">Unknown</td>
+ <td class="unreleased" align="center">Clang 19</td>
</tr>
<tr id="151">
<td><a href="https://cplusplus.github.io/CWG/issues/151.html">151</a></td>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should apply the suggested change, and run make_cxx_dr_status
script. I don't expect it to introduce new changes, though, but we should be on a safe side here, and not rely on manual editing of cxx_dr_status.html
.
834696f
to
5ecb3c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now.
The contents of the test go over my head, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.