From be2a5af09138a20b810abb5d46229a6416b3a585 Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sat, 11 May 2024 23:57:11 +0900 Subject: [PATCH] fix(utils/**.py): fix comparison to None from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or > is not, never the equality operators. --- utils/bazel/configure.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/bazel/configure.bzl b/utils/bazel/configure.bzl index 717b86d7d6e8a..9c3bb321a5afa 100644 --- a/utils/bazel/configure.bzl +++ b/utils/bazel/configure.bzl @@ -110,7 +110,7 @@ def _extract_cmake_settings(repository_ctx, llvm_cmake): # Skip if `CMAKE_CXX_STANDARD` is set with # `LLVM_REQUIRED_CXX_STANDARD`. # Then `v` will not be desired form, like "${...} CACHE" - if c[k] != None: + if c[k] is not None: continue # Pick up 1st word as the value. @@ -160,7 +160,7 @@ def _llvm_configure_impl(repository_ctx): repository_ctx, "cmake/Modules/LLVMVersion.cmake", ) - version = {k: v for k, v in version.items() if v != None} + version = {k: v for k, v in version.items() if v is not None} vars.update(version) _write_dict_to_file(