Skip to content

[OpenMP/Offload] Enable Offload runtime and add check #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jplehr
Copy link
Contributor

@jplehr jplehr commented Mar 19, 2024

This enables the new "offload" runtime that
llvm/llvm-project#75125 will create. In addition, it adds a new lit test target.
I removed the extra CMake argument that would again specify which runtimes to build manually, so that we rely on the factory to add the respective runtimes.

Since the PR does not make check-libomptarget available in the top level configuration, we have to change the ninja working directory into the runtimes build folder, where the target is known. Whether or not this works with this crude "additional lit checks" mechanism is an experiment.

This enables the new "offload" runtime that
llvm/llvm-project#75125 will create. In
addition, it adds a new lit test target.
I removed the extra CMake argument that would again specify which
runtimes to build manually, so that we rely on the factory to add the
respective runtimes.

Since the PR does not make `check-libomptarget` available in the
top level configuration, we have to change the ninja working directory
into the runtimes build folder, where the target is known. Whether or
not this works with this crude "additional lit checks" mechanism is an
experiment.
@jplehr
Copy link
Contributor Author

jplehr commented Mar 19, 2024

A couple of more comments:

  • This affects: https://lab.llvm.org/staging/#/builders/185
  • I think we should wait for @saiislam to let us know of the status on his downstreaming efforts of the llvm-project PR before proceeding with it and use this buildbot change as a test in the meantime to make sure that the add_lit_check works as intended.
  • This will make the bot red if it works. The message should be that it cded into the directory, but the target name is unknown. If the bot prints a different error, adding this target via the add_lit_checks liekly did not work.

@jplehr
Copy link
Contributor Author

jplehr commented Mar 19, 2024

I just realized that I'll have to change the patch to test the add_lit_checks mechanism. As it is now, the bot will bail out early, given that offload is unknown.

@jhuber6 jhuber6 changed the title [OpenMP/Offload] Enable Offlaod runtime and add check [OpenMP/Offload] Enable Offload runtime and add check Mar 19, 2024
@jplehr
Copy link
Contributor Author

jplehr commented Mar 19, 2024

I created #142 which should only add the additional lit target. Meaning that we can use it to see if the machinery is able to handle what we need.

@jplehr
Copy link
Contributor Author

jplehr commented Mar 20, 2024

I'll close this PR, since we discussed a different route during a meeting today.

@jplehr jplehr closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant