From 30ed54ffbf7c2f908e16ef1b8b2b3833e09dc85f Mon Sep 17 00:00:00 2001 From: Ihor Sviziev Date: Fri, 11 Sep 2020 15:42:29 +0300 Subject: [PATCH] Better solution for fixing array_merge in loop --- Magento2/Sniffs/Performance/ForeachArrayMergeSniff.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Magento2/Sniffs/Performance/ForeachArrayMergeSniff.md b/Magento2/Sniffs/Performance/ForeachArrayMergeSniff.md index 90bc6211..55f6969c 100644 --- a/Magento2/Sniffs/Performance/ForeachArrayMergeSniff.md +++ b/Magento2/Sniffs/Performance/ForeachArrayMergeSniff.md @@ -15,12 +15,11 @@ Typical example when `array_merge` is being used in the loop: In order to reduce execution time `array_merge` can be called only once: ``` php - $options = [[]]; + $options = []; foreach ($configurationSources as $source) { // code here $options[] = $source->getOptions(); } - // PHP 5.6+ - $options = array_merge(...$options); + $options = array_merge([], ...$options); ```