From 747265411c39e638434c8bacaaecc28353e2f703 Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Tue, 30 Nov 2021 18:52:59 -0500 Subject: [PATCH 1/5] clarify non-trading --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 93b61d7b..53b632b9 100644 --- a/README.md +++ b/README.md @@ -265,6 +265,9 @@ Notice, in the above chart, there are no gaps along the x-coordinate, even thoug - However, sometimes people like to see these gaps, so that they can tell, with a quick glance, where the weekends and holidays fall. - Non-trading days can be displayed with the `show_nontrading` keyword. + - Note that for these purposes **non-trading** intervals are those that ***are not represented in the data at all***. That is, there are simply no rows for those date (or datetimes). This is because data that is retrieved from an exchange or other market data source typically will *not* include rows for non-trading days (weekends and holidays for example). + - `show_nontrading=True` will display all dates (all time intervals) between the first time stamp and the last time stamp in the data (regardless of whether rows exist for those dates or datetimes). + - `show_nontrading=False` (the default value) will show ***only*** dates (or datetimes) that have actual rows in the data. (This means that if there are rows in your DataFrame that exist but contain only `NaN` values, these rows *will always* appear on the plot even if `show_nontrading=False`) - For example, in the chart below, you can easily see weekends, as well as a gap at Thursday, November 28th for the U.S. Thanksgiving holiday. From e52e2ff5314f65db0b065da92ea37d806b7a6cb8 Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Tue, 30 Nov 2021 18:57:58 -0500 Subject: [PATCH 2/5] tweak wording in clarify non-trading --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 53b632b9..2b96aa38 100644 --- a/README.md +++ b/README.md @@ -265,9 +265,9 @@ Notice, in the above chart, there are no gaps along the x-coordinate, even thoug - However, sometimes people like to see these gaps, so that they can tell, with a quick glance, where the weekends and holidays fall. - Non-trading days can be displayed with the `show_nontrading` keyword. - - Note that for these purposes **non-trading** intervals are those that ***are not represented in the data at all***. That is, there are simply no rows for those date (or datetimes). This is because data that is retrieved from an exchange or other market data source typically will *not* include rows for non-trading days (weekends and holidays for example). - - `show_nontrading=True` will display all dates (all time intervals) between the first time stamp and the last time stamp in the data (regardless of whether rows exist for those dates or datetimes). - - `show_nontrading=False` (the default value) will show ***only*** dates (or datetimes) that have actual rows in the data. (This means that if there are rows in your DataFrame that exist but contain only `NaN` values, these rows *will always* appear on the plot even if `show_nontrading=False`) + - Note that for these purposes **non-trading** intervals are those that ***are not represented in the data at all***. (There are simply no rows for those dates or datetimes). This is because, when data is retrieved from an exchange or other market data source, that data typically will *not* include rows for non-trading days (weekends and holidays for example). Thus ... + - **`show_nontrading=True`** will display all dates (all time intervals) between the first time stamp and the last time stamp in the data (regardless of whether rows exist for those dates or datetimes). + - **`show_nontrading=False`** (the default value) will show ***only*** dates (or datetimes) that have actual rows in the data. (This means that if there are rows in your DataFrame that exist but contain only **`NaN`** values, these rows *will still appear* on the plot even if **`show_nontrading=False`**) - For example, in the chart below, you can easily see weekends, as well as a gap at Thursday, November 28th for the U.S. Thanksgiving holiday. From f397957634c8d300d4e32a237a005c48a3fd464f Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Tue, 30 Nov 2021 18:59:44 -0500 Subject: [PATCH 3/5] tweak format in clarify non-trading --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2b96aa38..e0c1cdf7 100644 --- a/README.md +++ b/README.md @@ -264,7 +264,7 @@ Notice, in the above chart, there are no gaps along the x-coordinate, even thoug - However, sometimes people like to see these gaps, so that they can tell, with a quick glance, where the weekends and holidays fall. -- Non-trading days can be displayed with the `show_nontrading` keyword. +- Non-trading days can be displayed with the **`show_nontrading`** keyword. - Note that for these purposes **non-trading** intervals are those that ***are not represented in the data at all***. (There are simply no rows for those dates or datetimes). This is because, when data is retrieved from an exchange or other market data source, that data typically will *not* include rows for non-trading days (weekends and holidays for example). Thus ... - **`show_nontrading=True`** will display all dates (all time intervals) between the first time stamp and the last time stamp in the data (regardless of whether rows exist for those dates or datetimes). - **`show_nontrading=False`** (the default value) will show ***only*** dates (or datetimes) that have actual rows in the data. (This means that if there are rows in your DataFrame that exist but contain only **`NaN`** values, these rows *will still appear* on the plot even if **`show_nontrading=False`**) From 7f1042cb35946f21d4cfb6053a68056dbc02ea4e Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Tue, 30 Nov 2021 19:06:26 -0500 Subject: [PATCH 4/5] archive travis.yml file (not needed; using github actions instead) --- .travis.yml => archive.travis.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .travis.yml => archive.travis.yml (100%) diff --git a/.travis.yml b/archive.travis.yml similarity index 100% rename from .travis.yml rename to archive.travis.yml From 199d1a0ca6b486a5777d5418f2f018997babdce3 Mon Sep 17 00:00:00 2001 From: Daniel Goldfarb Date: Tue, 30 Nov 2021 19:06:57 -0500 Subject: [PATCH 5/5] bump version --- src/mplfinance/_version.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mplfinance/_version.py b/src/mplfinance/_version.py index a2f1512a..6b278725 100644 --- a/src/mplfinance/_version.py +++ b/src/mplfinance/_version.py @@ -1,7 +1,7 @@ -version_info = (0, 12, 8, 'beta', 1) +version_info = (0, 12, 8, 'beta', 2) _specifier_ = {'alpha': 'a','beta': 'b','candidate': 'rc','final': ''} __version__ = '%s.%s.%s%s'%(version_info[0], version_info[1], version_info[2], - '' if version_info[3]=='final' else _specifier_[version_info[3]]+str(version_info[4])) \ No newline at end of file + '' if version_info[3]=='final' else _specifier_[version_info[3]]+str(version_info[4]))