Skip to content

Commit ef172dc

Browse files
authored
fix: jan beta logo displayed in jan release (#4828)
1 parent 7e46295 commit ef172dc

14 files changed

+53
-88
lines changed

.github/workflows/jan-electron-build.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ jobs:
4040
with:
4141
ref: ${{ github.ref }}
4242
public_provider: github
43+
beta: false
44+
nightly: false
4345
new_version: ${{ needs.get-update-version.outputs.new_version }}
4446

4547
build-windows-x64:
@@ -49,6 +51,8 @@ jobs:
4951
with:
5052
ref: ${{ github.ref }}
5153
public_provider: github
54+
beta: false
55+
nightly: false
5256
new_version: ${{ needs.get-update-version.outputs.new_version }}
5357

5458
build-linux-x64:
@@ -58,6 +62,8 @@ jobs:
5862
with:
5963
ref: ${{ github.ref }}
6064
public_provider: github
65+
beta: false
66+
nightly: false
6167
new_version: ${{ needs.get-update-version.outputs.new_version }}
6268

6369
update_release_draft:
@@ -82,4 +88,4 @@ jobs:
8288
# config-name: my-config.yml
8389
# disable-autolabeler: true
8490
env:
85-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
91+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/template-build-linux-x64.yml

Lines changed: 16 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -55,55 +55,26 @@ jobs:
5555
if: inputs.beta == true && inputs.nightly != true
5656
shell: bash
5757
run: |
58-
echo "Icons before replacement:"
59-
ls -la electron/icons/
60-
61-
echo "Setting up beta icons"
62-
63-
# Replace the key icon files with move operations (no need for rm first)
64-
mv electron/icons/jan-beta-512x512.png electron/icons/512x512.png
65-
mv electron/icons/jan-beta.ico electron/icons/icon.ico
66-
mv electron/icons/jan-beta.png electron/icons/icon.png
67-
mv electron/icons/[email protected] electron/icons/[email protected]
68-
mv electron/icons/jan-beta-tray.png electron/icons/icon-tray.png
69-
70-
# Remove any remaining nightly icon files
71-
rm -f electron/icons/jan-nightly-512x512.png
72-
rm -f electron/icons/jan-nightly.ico
73-
rm -f electron/icons/jan-nightly.png
74-
rm -f electron/icons/[email protected]
75-
rm -f electron/icons/jan-nightly-tray.png
76-
77-
# Verify the replacement
78-
echo "Icons after replacement:"
79-
ls -la electron/icons/
58+
rm -rf electron/icons/*
59+
60+
cp electron/icons_dev/jan-beta-512x512.png electron/icons/512x512.png
61+
cp electron/icons_dev/jan-beta.ico electron/icons/icon.ico
62+
cp electron/icons_dev/jan-beta.png electron/icons/icon.png
63+
cp electron/icons_dev/[email protected] electron/icons/[email protected]
64+
cp electron/icons_dev/jan-beta-tray.png electron/icons/icon-tray.png
8065
8166
- name: Replace Icons for Nightly Build
8267
if: inputs.nightly == true && inputs.beta != true
8368
shell: bash
8469
run: |
85-
echo "Icons before replacement:"
86-
ls -la electron/icons/
87-
88-
echo "Setting up nightly icons"
89-
90-
# Replace the key icon files with move operations (no need for rm first)
91-
mv electron/icons/jan-nightly-512x512.png electron/icons/512x512.png
92-
mv electron/icons/jan-nightly.ico electron/icons/icon.ico
93-
mv electron/icons/jan-nightly.png electron/icons/icon.png
94-
mv electron/icons/[email protected] electron/icons/[email protected]
95-
mv electron/icons/jan-nightly-tray.png electron/icons/icon-tray.png
96-
97-
# Remove any remaining beta icon files
98-
rm -f electron/icons/jan-beta-512x512.png
99-
rm -f electron/icons/jan-beta.ico
100-
rm -f electron/icons/jan-beta.png
101-
rm -f electron/icons/[email protected]
102-
rm -f electron/icons/jan-beta-tray.png
103-
104-
# Verify the replacement
105-
echo "Icons after replacement:"
106-
ls -la electron/icons/
70+
rm -rf electron/icons/*
71+
72+
cp electron/icons_dev/jan-nightly-512x512.png electron/icons/512x512.png
73+
cp electron/icons_dev/jan-nightly.ico electron/icons/icon.ico
74+
cp electron/icons_dev/jan-nightly.png electron/icons/icon.png
75+
cp electron/icons_dev/[email protected] electron/icons/[email protected]
76+
cp electron/icons_dev/jan-nightly-tray.png electron/icons/icon-tray.png
77+
10778
10879
- name: Installing node
10980
uses: actions/setup-node@v1
@@ -213,4 +184,4 @@ jobs:
213184
uses: actions/upload-artifact@v4
214185
with:
215186
name: jan-linux-amd64-${{ inputs.new_version }}-AppImage
216-
path: ./electron/dist/*.AppImage
187+
path: ./electron/dist/*.AppImage

.github/workflows/template-build-macos.yml

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -65,31 +65,25 @@ jobs:
6565
if: inputs.beta == true && inputs.nightly != true
6666
shell: bash
6767
run: |
68-
rm -f electron/icons/512x512.png
69-
rm -f electron/icons/icon.ico
70-
rm -f electron/icons/icon.png
71-
rm -f electron/icons/[email protected]
72-
rm -f electron/icons/icon-tray.png
73-
mv electron/icons/jan-beta-512x512.png electron/icons/512x512.png
74-
mv electron/icons/jan-beta.ico electron/icons/icon.ico
75-
mv electron/icons/jan-beta.png electron/icons/icon.png
76-
mv electron/icons/[email protected] electron/icons/[email protected]
77-
mv electron/icons/jan-beta-tray.png electron/icons/icon-tray.png
68+
rm -rf electron/icons/*
69+
70+
cp electron/icons_dev/jan-beta-512x512.png electron/icons/512x512.png
71+
cp electron/icons_dev/jan-beta.ico electron/icons/icon.ico
72+
cp electron/icons_dev/jan-beta.png electron/icons/icon.png
73+
cp electron/icons_dev/[email protected] electron/icons/[email protected]
74+
cp electron/icons_dev/jan-beta-tray.png electron/icons/icon-tray.png
7875
7976
- name: Replace Icons for Nightly Build
8077
if: inputs.nightly == true && inputs.beta != true
8178
shell: bash
8279
run: |
83-
rm -f electron/icons/512x512.png
84-
rm -f electron/icons/icon.ico
85-
rm -f electron/icons/icon.png
86-
rm -f electron/icons/[email protected]
87-
rm -f electron/icons/icon-tray.png
88-
mv electron/icons/jan-nightly-512x512.png electron/icons/512x512.png
89-
mv electron/icons/jan-nightly.ico electron/icons/icon.ico
90-
mv electron/icons/jan-nightly.png electron/icons/icon.png
91-
mv electron/icons/[email protected] electron/icons/[email protected]
92-
mv electron/icons/jan-nightly-tray.png electron/icons/icon-tray.png
80+
rm -rf electron/icons/*
81+
82+
cp electron/icons_dev/jan-nightly-512x512.png electron/icons/512x512.png
83+
cp electron/icons_dev/jan-nightly.ico electron/icons/icon.ico
84+
cp electron/icons_dev/jan-nightly.png electron/icons/icon.png
85+
cp electron/icons_dev/[email protected] electron/icons/[email protected]
86+
cp electron/icons_dev/jan-nightly-tray.png electron/icons/icon-tray.png
9387
9488
- name: Installing node
9589
uses: actions/setup-node@v1
@@ -236,4 +230,4 @@ jobs:
236230
uses: actions/upload-artifact@v4
237231
with:
238232
name: jan-mac-universal-${{ inputs.new_version }}
239-
path: ./electron/dist/*.dmg
233+
path: ./electron/dist/*.dmg

.github/workflows/template-build-windows-x64.yml

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -64,31 +64,25 @@ jobs:
6464
if: inputs.beta == true && inputs.nightly != true
6565
shell: bash
6666
run: |
67-
rm -f electron/icons/512x512.png
68-
rm -f electron/icons/icon.ico
69-
rm -f electron/icons/icon.png
70-
rm -f electron/icons/[email protected]
71-
rm -f electron/icons/icon-tray.png
72-
mv electron/icons/jan-beta-512x512.png electron/icons/512x512.png
73-
mv electron/icons/jan-beta.ico electron/icons/icon.ico
74-
mv electron/icons/jan-beta.png electron/icons/icon.png
75-
mv electron/icons/[email protected] electron/icons/[email protected]
76-
mv electron/icons/jan-beta-tray.png electron/icons/icon-tray.png
67+
rm -rf electron/icons/*
68+
69+
cp electron/icons_dev/jan-beta-512x512.png electron/icons/512x512.png
70+
cp electron/icons_dev/jan-beta.ico electron/icons/icon.ico
71+
cp electron/icons_dev/jan-beta.png electron/icons/icon.png
72+
cp electron/icons_dev/[email protected] electron/icons/[email protected]
73+
cp electron/icons_dev/jan-beta-tray.png electron/icons/icon-tray.png
7774
7875
- name: Replace Icons for Nightly Build
7976
if: inputs.nightly == true && inputs.beta != true
8077
shell: bash
8178
run: |
82-
rm -f electron/icons/512x512.png
83-
rm -f electron/icons/icon.ico
84-
rm -f electron/icons/icon.png
85-
rm -f electron/icons/[email protected]
86-
rm -f electron/icons/icon-tray.png
87-
mv electron/icons/jan-nightly-512x512.png electron/icons/512x512.png
88-
mv electron/icons/jan-nightly.ico electron/icons/icon.ico
89-
mv electron/icons/jan-nightly.png electron/icons/icon.png
90-
mv electron/icons/[email protected] electron/icons/[email protected]
91-
mv electron/icons/jan-nightly-tray.png electron/icons/icon-tray.png
79+
rm -rf electron/icons/*
80+
81+
cp electron/icons_dev/jan-nightly-512x512.png electron/icons/512x512.png
82+
cp electron/icons_dev/jan-nightly.ico electron/icons/icon.ico
83+
cp electron/icons_dev/jan-nightly.png electron/icons/icon.png
84+
cp electron/icons_dev/[email protected] electron/icons/[email protected]
85+
cp electron/icons_dev/jan-nightly-tray.png electron/icons/icon-tray.png
9286
9387
- name: Installing node
9488
uses: actions/setup-node@v1
@@ -232,4 +226,4 @@ jobs:
232226
uses: actions/upload-artifact@v4
233227
with:
234228
name: jan-win-x64-${{ inputs.new_version }}
235-
path: ./electron/dist/*.exe
229+
path: ./electron/dist/*.exe
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)