ENH: adjust meson install default arguments

The install directory is always a temporary directory, thus passing
the --only-changed option does not serve any purpose. When meson
install is run the project has been just been built, thus it is not
necessary to rebuild it: add the --no-rebuild option.

Author: dnicolodi

docs/explanations/default-options.rst

@@ -56,14 +56,13 @@ The options that ``meson-python`` specifies by default are:
 
 .. option:: buildtype=release
 
-   The Meson default is to produce a *debug* build with binaries
+   The Meson default is to produce a debug build with binaries
    compiled with debug symbols and, when compiling with MSVC, linking
    to the Visual Studio debug runtime, see below. The main purpose of
    ``meson-python`` is to build release artifacts, therefore a more
-   appropriate `build type`__ is selected. A *release* build is
-   compiled without debug symbols and with compiler
-   optimizations. Refer to the `Meson documentation`__ for more
-   details.
+   appropriate `build type`__ is selected. A release build is compiled
+   without debug symbols and with compiler optimizations. Refer to the
+   `Meson documentation`__ for more details.
 
 __ https://mesonbuild.com/Builtin-options.html#details-for-buildtype
 __ https://mesonbuild.com/Builtin-options.html#core-options
@@ -74,21 +73,22 @@ __ https://mesonbuild.com/Builtin-options.html#core-options
    disable assertions for release builds. For most users this is a
    surprising and undesired behavior. This option instructs Meson to
    pass the ``-DNDEBUG`` option to the compilers, unless the build
-   type is set to something else than *release*.
+   type is set to something else than release.
 
 .. option:: b_vscrt=md
 
-   By default, Meson instructs the MSVC compiler to use the debug
-   version of the VS runtime library when the build type is set to
-   *debug*. This causes the linker look for the debug build of all the
-   linked DLLs. The Python distribution for Windows does not contain a
-   debug version of the Python DLL and linking fails. The linking
-   failures are hard to diagnose. To avoid this issue when users
-   explicitly asks for a debug build, ``meson-python`` sets this
-   options to instruct Meson to compile with version of the Visual
-   Studio runtime. For more details, refer to the `Meson
-   documentation`__ and to the `Visual Studio documentation`__ . This
-   option is ignored when other compilers are used.
+   With the default options, when compiling a debug build, Meson
+   instructs the MSVC compiler to use the debug version of the Visual
+   Studio runtime library. This causes the MSVC linker to look for the
+   debug build of all the linked DLLs. The Python distribution for
+   Windows does not contain a debug version of the Python DLL and
+   linking fails. These linking failures are surprising and hard to
+   diagnose. To avoid this issue when users explicitly asks for a
+   debug build, ``meson-python`` sets this options to instruct Meson
+   to compile with the release version of the Visual Studio
+   runtime. For more details, refer to the `Meson documentation`__ and
+   to the `Visual Studio documentation`__ . This option is ignored
+   when other compilers are used.
 
 __ https://mesonbuild.com/Builtin-options.html#base-options
 __ https://learn.microsoft.com/en-us/cpp/build/reference/md-mt-ld-use-run-time-library?view=msvc-170

mesonpy/__init__.py

@@ -788,18 +788,11 @@ def _wheel_builder(self) -> _WheelBuilder:
             self._install_plan,
         )
 
-    def build_commands(self, install_dir: Optional[pathlib.Path] = None) -> Sequence[Sequence[str]]:
+    def build_commands(self) -> Sequence[Sequence[str]]:
         assert self._ninja is not None  # help mypy out
         return (
             (self._ninja, *self._meson_args['compile'],),
-            (
-                'meson',
-                'install',
-                '--only-changed',
-                '--destdir',
-                os.fspath(install_dir or self._install_dir),
-                *self._meson_args['install'],
-            ),
+            ('meson', 'install', '--no-rebuild', '--destdir', os.fspath(self._install_dir), *self._meson_args['install']),
         )
 
     @functools.lru_cache(maxsize=None)