-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Closed
Labels
Help WantedYou can do thisYou can do thisInfrastructureIssue relates to TypeScript team infrastructureIssue relates to TypeScript team infrastructure
Milestone
Description
While doing #25656 I see that jakefile has an error at https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L504
because that function has three needed parameters. See jsdoc at implementation (the third is not optional):
https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L816-L839
The implementation treats the third parameter as optional, but the only call to this function don't use it.
Is better remove the third parameter or make it optional?
CC @RyanCavanaugh since you changed this code the last time.
Metadata
Metadata
Assignees
Labels
Help WantedYou can do thisYou can do thisInfrastructureIssue relates to TypeScript team infrastructureIssue relates to TypeScript team infrastructure