Allow import assertions on esm imports under module: nodenext

[weswigham]

Fixes #46372

[andrewbranch]

Suggested change

	"Import assertions are not allowed on statements that transpile to commonjs require calls.": {
	"Import assertions are not allowed on statements that transpile to CommonJS 'require' calls.": {

[gabritto]

As someone who doesn't know that much about modules and import assertions, the error message that says "Import assertions are not allowed on statements that transpile to commonjs 'require' calls" looks a bit puzzling, even though it's accurate. But I don't know how that could be improved; maybe instead of saying "statements that transpile to CommonJs..." we could explicitly list the scenarios when this is true? That might be too verbose and not helpful either...

Otherwise this looks good.

[andrewbranch]

@typescript-bot cherry-pick this to release-4.5

[typescript-bot]

Heya @andrewbranch, I've started to run the task to cherry-pick this into release-4.5 on this PR at b48868d. You can monitor the build here.

[typescript-bot]

Hey @andrewbranch, I've opened #46648 for you.

[weswigham]

could explicitly list the scenarios when this is true?

I think "import declarations and external reexport declarations in a cjs mode file except for dynamic import expressions" is a bit of a mouthful. And probably not much better.