Add a test for a destructured union with tuple members #46656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
@sandersn feel free to decide if it’s worth merging or if this is duplicating the tests from that other PR. When i’ve seen that PR being merged into your main branch i’ve went to look up the added tests and I wasn’t sure if the destructured array pattern would behave the same as destructured object pattern. So i’ve decided to add this test and check out what happens - for you both patterns might be almost the same, for me, a user who tried to use tests as docs, it wasnt that obvious |
sandersn
approved these changes
Dec 7, 2021
mprobst
pushed a commit
to mprobst/TypeScript
that referenced
this pull request
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is test-only PR. I've noticed this awesome, awesome PR and went testing it right away, looking through the added tests etc. There was no test like this so I wasn't sure if this would work by looking at tests alone and I've decided to just add them after verifying that this works.