From be10ba2990f3f2b1f828ba47de8753cbe9667be4 Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Date: Mon, 8 Nov 2021 09:02:25 -0800 Subject: [PATCH] Big[U]Int64Array.at returns bigint, not number bigint is needed to represent all 64-bit ints that these arrays could contain. --- src/lib/es2022.array.d.ts | 4 ++-- .../baselines/reference/indexAt(target=es2022).types | 12 ++++++------ .../baselines/reference/indexAt(target=esnext).types | 12 ++++++------ 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/lib/es2022.array.d.ts b/src/lib/es2022.array.d.ts index 2c68a99c91e1f..68a797f8275d3 100644 --- a/src/lib/es2022.array.d.ts +++ b/src/lib/es2022.array.d.ts @@ -91,7 +91,7 @@ interface BigInt64Array { * Returns the item located at the specified index. * @param index The zero-based index of the desired code unit. A negative index will count back from the last item. */ - at(index: number): number | undefined; + at(index: number): bigint | undefined; } interface BigUint64Array { @@ -99,5 +99,5 @@ interface BigUint64Array { * Returns the item located at the specified index. * @param index The zero-based index of the desired code unit. A negative index will count back from the last item. */ - at(index: number): number | undefined; + at(index: number): bigint | undefined; } diff --git a/tests/baselines/reference/indexAt(target=es2022).types b/tests/baselines/reference/indexAt(target=es2022).types index 36fbb503e4258..acd40c3f67572 100644 --- a/tests/baselines/reference/indexAt(target=es2022).types +++ b/tests/baselines/reference/indexAt(target=es2022).types @@ -87,18 +87,18 @@ new Float64Array().at(0); >0 : 0 new BigInt64Array().at(0); ->new BigInt64Array().at(0) : number ->new BigInt64Array().at : (index: number) => number +>new BigInt64Array().at(0) : bigint +>new BigInt64Array().at : (index: number) => bigint >new BigInt64Array() : BigInt64Array >BigInt64Array : BigInt64ArrayConstructor ->at : (index: number) => number +>at : (index: number) => bigint >0 : 0 new BigUint64Array().at(0); ->new BigUint64Array().at(0) : number ->new BigUint64Array().at : (index: number) => number +>new BigUint64Array().at(0) : bigint +>new BigUint64Array().at : (index: number) => bigint >new BigUint64Array() : BigUint64Array >BigUint64Array : BigUint64ArrayConstructor ->at : (index: number) => number +>at : (index: number) => bigint >0 : 0 diff --git a/tests/baselines/reference/indexAt(target=esnext).types b/tests/baselines/reference/indexAt(target=esnext).types index 36fbb503e4258..acd40c3f67572 100644 --- a/tests/baselines/reference/indexAt(target=esnext).types +++ b/tests/baselines/reference/indexAt(target=esnext).types @@ -87,18 +87,18 @@ new Float64Array().at(0); >0 : 0 new BigInt64Array().at(0); ->new BigInt64Array().at(0) : number ->new BigInt64Array().at : (index: number) => number +>new BigInt64Array().at(0) : bigint +>new BigInt64Array().at : (index: number) => bigint >new BigInt64Array() : BigInt64Array >BigInt64Array : BigInt64ArrayConstructor ->at : (index: number) => number +>at : (index: number) => bigint >0 : 0 new BigUint64Array().at(0); ->new BigUint64Array().at(0) : number ->new BigUint64Array().at : (index: number) => number +>new BigUint64Array().at(0) : bigint +>new BigUint64Array().at : (index: number) => bigint >new BigUint64Array() : BigUint64Array >BigUint64Array : BigUint64ArrayConstructor ->at : (index: number) => number +>at : (index: number) => bigint >0 : 0