Skip to content

fix(54366): bug: getCodeFixesAtPosition fails when TS2339 diagnostic paired with large pojo; Debug Failure. False expression: Token end is child end #54432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

fix(54366): bug: getCodeFixesAtPosition fails when TS2339 diagnostic paired with large pojo; Debug Failure. False expression: Token end is child end #54432

merged 1 commit into from
May 30, 2023

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #54366

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 28, 2023
jakebailey
jakebailey approved these changes May 28, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I wonder how many more of these are sitting around...

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 29, 2023 •
edited
Loading

There are plenty I'm sure. And even when you use NoTruncation we will have a text cutoff, so you can still end up with totally jumbled text that can't be formatted - just ask @MariaSolOs.

But you could likely grep across the entire codefixes/refactorings files for places that take NodeBuilderFlags to find them.

@DanielRosenwasser DanielRosenwasser merged commit d495200 into microsoft:main May 30, 2023
@iisaduan iisaduan mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: getCodeFixesAtPosition fails when TS2339 diagnostic paired with large pojo; Debug Failure. False expression: Token end is child end
4 participants
@a-tarasyuk @DanielRosenwasser @jakebailey @typescript-bot