Skip to content

Completions capability flag #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PederHP
Copy link
Contributor

@PederHP PederHP commented Feb 22, 2025

Motivation and Context

The completions capability is the only one without a ServerCapabilities flag, which doesn't make sense as not all servers will support it, and clients should be able to query that up front to avoid calling the method. See #157.

How Has This Been Tested?

Not yet no. It's relatively trivial and aligns with the capability flags. I'll implement this in mcpdotnet if/when the PR is merged.

Breaking Changes

In principle yes, as servers should now expose the completions capability explicitly. After this change, clients that query servers may assume that a server not exposing the capability does not support it. In practice, this capability is so tightly coupled to server documentation (as there is no mechanism for servers to communicate what completion parameters they support) that clients will likely be hardcoded to use completions with specific servers, making this a breaking change in theory only.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for the delayed review.

@jspahrsummers jspahrsummers merged commit 4823482 into modelcontextprotocol:main Mar 26, 2025
@github-project-automation github-project-automation bot moved this from Consulting to Approved in Standards Track Mar 26, 2025
kentcdodds added a commit to kentcdodds/modelcontextprotocol that referenced this pull request May 28, 2025
@dsp-ant dsp-ant added this to the DRAFT: 2025-03-26 milestone Jun 5, 2025
@jonathanhefner jonathanhefner linked an issue Jun 27, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

Completion Capability as Optional via Server Capabilities
3 participants