Skip to content

Commit fad816b

Browse files
committed
fix(data-modeling): do not use memoize for relationship filter
1 parent a2967fd commit fad816b

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

packages/compass-data-modeling/src/components/relationship-drawer-content.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ import {
1313
import {
1414
deleteRelationship,
1515
getCurrentDiagramFromState,
16+
getRelationshipForCurrentModel,
1617
selectFieldsForCurrentModel,
17-
selectRelationshipForCurrentModel,
1818
updateRelationship,
1919
} from '../store/diagram';
2020
import toNS from 'mongodb-ns';
@@ -288,7 +288,7 @@ const RelationshipDrawerContent: React.FunctionComponent<
288288
export default connect(
289289
(state: DataModelingState, ownProps: { relationshipId: string }) => {
290290
const diagram = getCurrentDiagramFromState(state);
291-
const relationship = selectRelationshipForCurrentModel(
291+
const relationship = getRelationshipForCurrentModel(
292292
diagram.edits,
293293
ownProps.relationshipId
294294
);

packages/compass-data-modeling/src/store/diagram.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -620,15 +620,11 @@ function getFieldsForCurrentModel(
620620

621621
export const selectFieldsForCurrentModel = memoize(getFieldsForCurrentModel);
622622

623-
function getRelationshipForCurrentModel(
623+
export function getRelationshipForCurrentModel(
624624
edits: MongoDBDataModelDescription['edits'],
625625
relationshipId: string
626626
) {
627627
return selectCurrentModel(edits).relationships.find(
628628
(r) => r.id === relationshipId
629629
);
630630
}
631-
632-
export const selectRelationshipForCurrentModel = memoize(
633-
getRelationshipForCurrentModel
634-
);

0 commit comments

Comments
 (0)