fix: bump LG packages COMPASS-9496 #7109
Conversation
paula-stacho
force-pushed
the
COMPASS-9496
branch
from
2a1ad74 to
8e71682
Compare
| "@leafygreen-ui/button": "^24.0.2", | ||
| "@leafygreen-ui/card": "^13.0.2", | ||
| "@leafygreen-ui/checkbox": "^18.0.0", | ||
| "@leafygreen-ui/chip": "^4.0.2", | ||
| "@leafygreen-ui/code": "^16.0.2", |
There was a problem hiding this comment.
I'm guessing you're skipping this because of the failing postinstall, it's failing due to @lg-tools dependency not being included in the package deps. We can ask lg team if they intentionally added postinstall here and not something like prepublishOnly and as a workaround we can also just add @lg-tools/build package as a dev dependency to make sure all leafygreen is updated to latest, this is important
package-lock.json
Outdated
There was a problem hiding this comment.
This seems off, I'm getting a 8k LoC diff for package-lock locally updating leafygreen to latest on main, this is 28k (I'm bumping code package too though, it's definitely a factor, but this still seems wildly different)
There was a problem hiding this comment.
Yeah I noticed the number now that I opened the draft. I've tried rebasing of main but it didn't help. I'll try the code package tomorrow, but it'd be weird if it made that much difference
| } | ||
| return undefined; | ||
| }, [href, utmSource, utmMedium]); | ||
| }, [props, utmSource, utmMedium]); |
There was a problem hiding this comment.
This makes memo here and in other cases practically useless: the props object is being regenerated every render
paula-stacho
force-pushed
the
COMPASS-9496
branch
from
3f818bc to
6e574ac
Compare
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes