fix(compass-indexes): update tooltip when server version should support search indexes but fetch fails COMPASS-9378 #7122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Jul 18, 2025
| can manage your Atlas Search indexes from the Atlas web | ||
| Ul, with the CLI, or with the Administration API. | ||
| </p> | ||
| {semver.gte(serverVersion, '6.0.7') ? ( |
There was a problem hiding this comment.
semver will fail if the version can't be parsed (which happens occasionally for compass users), you should wrap this call in a way that handles the failed parsing (you can look at semver usage in this package as a reference)
There was a problem hiding this comment.
sounds good, fixed
gribnoysup
approved these changes
Jul 21, 2025
| MIN_SEARCH_INDEX_MANAGEMENT_SERVER_VERSION | ||
| ); | ||
| } catch { | ||
| return true; |
There was a problem hiding this comment.
I think we might want this to be false if we couldn't parse the version (usually when we encounter this people are running some unexpected server builds / versions), but I trust you know better. It's also a rare case, so maybe not worth overthinking too much
There was a problem hiding this comment.
yeah that makes sense, fixed it
Anemy
approved these changes
Jul 21, 2025
packages/compass-indexes/src/components/indexes-toolbar/indexes-toolbar.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Rhys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unable to fetch search indexes. This can occur when your cluster does not support search indexes or the listing search indexes request failed.when server version should support search indexesChecklist
Motivation and Context
Open Questions
Dependents
Types of changes