Skip to content

Commit 60811cb

Browse files
committed
Revert "Prohibit deactivating transaction management with AUTOCOMMIT=False in DATABASES"
This reverts commit c7831c6.
1 parent c7831c6 commit 60811cb

File tree

3 files changed

+0
-19
lines changed

3 files changed

+0
-19
lines changed

django_mongodb_backend/base.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,6 @@ def __init__(self, settings_dict, alias=DEFAULT_DB_ALIAS):
159159
super().__init__(settings_dict, alias=alias)
160160
self.session = None
161161

162-
def check_settings(self):
163-
super().check_settings()
164-
if not self.settings_dict["AUTOCOMMIT"]:
165-
raise ImproperlyConfigured("MongoDB does not support AUTOCOMMIT=False.")
166-
167162
def get_collection(self, name, **kwargs):
168163
collection = Collection(self.database, name, **kwargs)
169164
if self.queries_logged:

docs/source/ref/database.rst

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,6 @@ default behavior of autocommit mode. Each query is immediately committed to the
5858
database. Django's transaction management APIs, such as
5959
:func:`~django.db.transaction.atomic`, function as no-ops.
6060

61-
:ref:`Deactivating transaction management <django:deactivate-transaction-management>`
62-
by setting :setting:`AUTOCOMMIT <DATABASE-AUTOCOMMIT>` to ``False`` in the
63-
:setting:`DATABASES` setting isn't supported.
64-
6561
.. _transactions-limitations:
6662

6763
Limitations

tests/backend_/test_base.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import copy
2-
31
from django.core.exceptions import ImproperlyConfigured
42
from django.db import connection
53
from django.db.backends.signals import connection_created
@@ -16,14 +14,6 @@ def test_database_name_empty(self):
1614
with self.assertRaisesMessage(ImproperlyConfigured, msg):
1715
DatabaseWrapper(settings).get_connection_params()
1816

19-
def test_autocommit_false(self):
20-
new_connection = connection.copy()
21-
new_connection.settings_dict = copy.deepcopy(connection.settings_dict)
22-
new_connection.settings_dict["AUTOCOMMIT"] = False
23-
msg = "MongoDB does not support AUTOCOMMIT=False."
24-
with self.assertRaisesMessage(ImproperlyConfigured, msg):
25-
new_connection.check_settings()
26-
2717

2818
class DatabaseWrapperConnectionTests(TransactionTestCase):
2919
available_apps = ["backend_"]

0 commit comments

Comments
 (0)