Set() stage builder #512
Set() stage builder #512
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
norareidy
requested review from
a team and
rstam
and removed request for
a team
|
|
||
| var pipeline = new EmptyPipelineDefinition<Flower>() | ||
| .Match(matchFilter) | ||
| .Set(fields); |
There was a problem hiding this comment.
Have you tried executing this?
Most likely it will throw an exception when reading the results from the server because the C# declaration for Flower does not have a Color property.
There was a problem hiding this comment.
Ah yep, I added Color to the Flower class while testing and just added it to the page. But does that defeat the purpose of Set()?
There was a problem hiding this comment.
Good point. It looks like the API for Set is defective. Let me discuss with the team.
There was a problem hiding this comment.
The current implementation of Set assumes that you are using Set to change the value of existing fields.
I will be creating a JIRA ticket to cover the scenario where you want to use Set to add new fields. This will require adding a TNewResult type parameter to represent the new result with the new additional fields.
But we should wait until that gets implemented to update the documentation.
So for now let's document setting existing fields.
There was a problem hiding this comment.
p.s. I wrote the above comment a long time ago but apparently didn't submit it because it still showed as "pending".
There was a problem hiding this comment.
So I think that means we should not merge this PR at this time.
source/fundamentals/builders.txt
Outdated
| Add Fields to Collection Documents | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| You can add new fields to existing documents in a collection |
There was a problem hiding this comment.
This might be a bit misleading because the documents in the collection are NOT modified.
The new fields are only added to the documents going through the pipeline, the original documents that are input to the pipeline are unchanged.
There was a problem hiding this comment.
Okay, I removed mentions of "collection" and just kept it as "You can add new fields to documents"
|
|
||
| var pipeline = new EmptyPipelineDefinition<Flower>() | ||
| .Match(matchFilter) | ||
| .Set(fields); |
There was a problem hiding this comment.
Good point. It looks like the API for Set is defective. Let me discuss with the team.
|
@norareidy I added a C# example to the $set Server page; do you think we can close this PR? https://www.mongodb.com/docs/upcoming/reference/operator/aggregation/set/#examples |
If Set() is now working as expected I can just merge this PR; @rstam are there any updates on that? |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-33526
Staging Links
Self-Review Checklist