Skip to content

DOCSP-50554: Add extra AWS info to OIDC page #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2025
Merged

DOCSP-50554: Add extra AWS info to OIDC page #648

merged 5 commits into from
Jun 17, 2025

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jun 12, 2025 •
edited by github-actions bot
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-50554

Staging Links

  • fundamentals/authentication/oidc

    • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?
    • Did you add redirects?

    @netlify Netlify
    Copy link

    netlify bot commented Jun 12, 2025 •
    edited
    Loading

    ✅ Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit 28c0a77
    🔍 Latest deploy log https://app.netlify.com/projects/docs-csharp/deploys/684b3da92ffafb0008935416
    😎 Deploy Preview https://deploy-preview-648--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    rustagir
    rustagir reviewed Jun 12, 2025
    View reviewed changes
    rustagir
    rustagir approved these changes Jun 12, 2025
    View reviewed changes
    Copy link
    Contributor

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    style guide fixes, but lgtm

    @mcmorisi mcmorisi requested review from a team and sanych-sun and removed request for a team June 12, 2025 20:51
    sanych-sun
    sanych-sun approved these changes Jun 17, 2025
    View reviewed changes
    Copy link
    Member

    @sanych-sun sanych-sun left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @mcmorisi mcmorisi merged commit 487132e into mongodb:master Jun 17, 2025
    6 of 7 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-50554-oidc-aws branch June 17, 2025 18:16
    mcmorisi added a commit that referenced this pull request Jun 17, 2025
    @mcmorisi
    DOCSP-50554: Add extra AWS info to OIDC page (#648)
    ef13a0a 
    (cherry picked from commit 487132e)
    mcmorisi added a commit that referenced this pull request Jun 17, 2025
    @mcmorisi
    DOCSP-50554: Add extra AWS info to OIDC page (#648)
    7751a8a 
    (cherry picked from commit 487132e)
    mcmorisi added a commit that referenced this pull request Jun 17, 2025
    @mcmorisi
    DOCSP-50554: Add extra AWS info to OIDC page (#648)
    11749e8 
    (cherry picked from commit 487132e)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @sanych-sun sanych-sun sanych-sun approved these changes

    @rustagir rustagir rustagir approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @mcmorisi @sanych-sun @rustagir