From a5a93dcde7ecb9044b9d2f6a9f917e27147a2cb5 Mon Sep 17 00:00:00 2001 From: Jeremy Mikola Date: Thu, 7 Nov 2024 08:31:12 -0500 Subject: [PATCH] Fix PHPUnit deprecation notices This addresses several "Providing invalid named argument" notices. PHPUnit 11 will require keys in data providers to match method argument names. --- tests/Operation/WatchFunctionalTest.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Operation/WatchFunctionalTest.php b/tests/Operation/WatchFunctionalTest.php index 15326f696..6e57361ed 100644 --- a/tests/Operation/WatchFunctionalTest.php +++ b/tests/Operation/WatchFunctionalTest.php @@ -488,7 +488,7 @@ public function testRewindMultipleTimesWithNoResults(): void } #[DataProvider('provideCodecOptions')] - public function testNoChangeAfterResumeBeforeInsert(array $options): void + public function testNoChangeAfterResumeBeforeInsert(array $options, Closure $getIdentifier): void { $operation = new Watch( $this->manager, @@ -1427,7 +1427,7 @@ public function testGetResumeTokenReturnsOriginalResumeTokenOnEmptyBatch(): void * - If neither the startAfter nor resumeAfter options were specified, the getResumeToken result must be empty. */ #[DataProvider('provideCodecOptions')] - public function testResumeTokenBehaviour(array $options): void + public function testResumeTokenBehaviour(array $options, Closure $getIdentifier): void { $this->skipIfServerVersion('<', '4.1.1', 'Testing resumeAfter and startAfter can only be tested on servers >= 4.1.1'); $this->skipIfIsShardedCluster('Resume token behaviour can\'t be reliably tested on sharded clusters.');