diff --git a/src/main/java/org/mybatis/dynamic/sql/select/render/FetchFirstPagingModelRenderer.java b/src/main/java/org/mybatis/dynamic/sql/select/render/FetchFirstPagingModelRenderer.java
index 5d7eaf285..ab300d16f 100644
--- a/src/main/java/org/mybatis/dynamic/sql/select/render/FetchFirstPagingModelRenderer.java
+++ b/src/main/java/org/mybatis/dynamic/sql/select/render/FetchFirstPagingModelRenderer.java
@@ -1,21 +1,22 @@
/**
- * Copyright 2016-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Copyright 2016-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.mybatis.dynamic.sql.select.render;
import java.util.Optional;
+import java.util.concurrent.atomic.AtomicInteger;
import org.mybatis.dynamic.sql.render.RenderingStrategy;
import org.mybatis.dynamic.sql.select.PagingModel;
@@ -26,13 +27,15 @@ public class FetchFirstPagingModelRenderer {
private static final String OFFSET_PARAMETER = "_offset"; //$NON-NLS-1$
private RenderingStrategy renderingStrategy;
private PagingModel pagingModel;
+ private AtomicInteger sequence;
public FetchFirstPagingModelRenderer(RenderingStrategy renderingStrategy,
- PagingModel pagingModel) {
+ PagingModel pagingModel, AtomicInteger sequence) {
this.renderingStrategy = renderingStrategy;
this.pagingModel = pagingModel;
+ this.sequence = sequence;
}
-
+
public Optional render() {
return pagingModel.offset()
.map(this::renderWithOffset)
@@ -44,37 +47,45 @@ private Optional renderWithOffset(Long offset) {
.map(ffr -> renderOffsetAndFetchFirstRows(offset, ffr))
.orElseGet(() -> renderOffsetOnly(offset));
}
-
+
private Optional renderFetchFirstRowsOnly() {
return pagingModel.fetchFirstRows().flatMap(this::renderFetchFirstRowsOnly);
}
-
+
private Optional renderFetchFirstRowsOnly(Long fetchFirstRows) {
+ String mapKey = formatParameterMapKey(FETCH_FIRST_ROWS_PARAMETER);
return FragmentAndParameters
- .withFragment("fetch first " + renderPlaceholder(FETCH_FIRST_ROWS_PARAMETER) //$NON-NLS-1$
- + " rows only") //$NON-NLS-1$
- .withParameter(FETCH_FIRST_ROWS_PARAMETER, fetchFirstRows)
+ .withFragment("fetch first " + renderPlaceholder(mapKey) //$NON-NLS-1$
+ + " rows only") //$NON-NLS-1$
+ .withParameter(mapKey, fetchFirstRows)
.buildOptional();
}
-
+
private Optional renderOffsetOnly(Long offset) {
- return FragmentAndParameters.withFragment("offset " + renderPlaceholder(OFFSET_PARAMETER) //$NON-NLS-1$
- + " rows") //$NON-NLS-1$
- .withParameter(OFFSET_PARAMETER, offset)
+ String mapKey = formatParameterMapKey(OFFSET_PARAMETER);
+ return FragmentAndParameters.withFragment("offset " + renderPlaceholder(mapKey) //$NON-NLS-1$
+ + " rows") //$NON-NLS-1$
+ .withParameter(mapKey, offset)
.buildOptional();
}
-
+
private Optional renderOffsetAndFetchFirstRows(Long offset, Long fetchFirstRows) {
- return FragmentAndParameters.withFragment("offset " + renderPlaceholder(OFFSET_PARAMETER) //$NON-NLS-1$
- + " rows fetch first " + renderPlaceholder(FETCH_FIRST_ROWS_PARAMETER) //$NON-NLS-1$
- + " rows only") //$NON-NLS-1$
- .withParameter(OFFSET_PARAMETER, offset)
- .withParameter(FETCH_FIRST_ROWS_PARAMETER, fetchFirstRows)
+ String mapKey1 = formatParameterMapKey(OFFSET_PARAMETER);
+ String mapKey2 = formatParameterMapKey(FETCH_FIRST_ROWS_PARAMETER);
+ return FragmentAndParameters.withFragment("offset " + renderPlaceholder(mapKey1) //$NON-NLS-1$
+ + " rows fetch first " + renderPlaceholder(mapKey2) //$NON-NLS-1$
+ + " rows only") //$NON-NLS-1$
+ .withParameter(mapKey1, offset)
+ .withParameter(mapKey2, fetchFirstRows)
.buildOptional();
}
-
+
+ private String formatParameterMapKey(String parameterMapKey) {
+ return parameterMapKey + sequence.getAndIncrement(); //$NON-NLS-1$
+ }
+
private String renderPlaceholder(String parameterName) {
return renderingStrategy.getFormattedJdbcPlaceholder(RenderingStrategy.DEFAULT_PARAMETER_PREFIX,
- parameterName);
+ parameterName);
}
}
diff --git a/src/main/java/org/mybatis/dynamic/sql/select/render/LimitAndOffsetPagingModelRenderer.java b/src/main/java/org/mybatis/dynamic/sql/select/render/LimitAndOffsetPagingModelRenderer.java
index a46a8e2ac..6ed0a3331 100644
--- a/src/main/java/org/mybatis/dynamic/sql/select/render/LimitAndOffsetPagingModelRenderer.java
+++ b/src/main/java/org/mybatis/dynamic/sql/select/render/LimitAndOffsetPagingModelRenderer.java
@@ -1,21 +1,22 @@
/**
- * Copyright 2016-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Copyright 2016-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.mybatis.dynamic.sql.select.render;
import java.util.Optional;
+import java.util.concurrent.atomic.AtomicInteger;
import org.mybatis.dynamic.sql.render.RenderingStrategy;
import org.mybatis.dynamic.sql.select.PagingModel;
@@ -27,35 +28,44 @@ public class LimitAndOffsetPagingModelRenderer {
private RenderingStrategy renderingStrategy;
private Long limit;
private PagingModel pagingModel;
+ private AtomicInteger sequence;
public LimitAndOffsetPagingModelRenderer(RenderingStrategy renderingStrategy,
- Long limit, PagingModel pagingModel) {
+ Long limit, PagingModel pagingModel, AtomicInteger sequence) {
this.renderingStrategy = renderingStrategy;
this.limit = limit;
this.pagingModel = pagingModel;
+ this.sequence = sequence;
}
-
+
public Optional render() {
return pagingModel.offset().map(this::renderLimitAndOffset)
.orElseGet(this::renderLimitOnly);
}
private Optional renderLimitOnly() {
- return FragmentAndParameters.withFragment("limit " + renderPlaceholder(LIMIT_PARAMETER)) //$NON-NLS-1$
- .withParameter(LIMIT_PARAMETER, limit)
+ String mapKey = formatParameterMapKey(LIMIT_PARAMETER);
+ return FragmentAndParameters.withFragment("limit " + renderPlaceholder(mapKey)) //$NON-NLS-1$
+ .withParameter(mapKey, limit)
.buildOptional();
}
-
+
private Optional renderLimitAndOffset(Long offset) {
- return FragmentAndParameters.withFragment("limit " + renderPlaceholder(LIMIT_PARAMETER) //$NON-NLS-1$
- + " offset " + renderPlaceholder(OFFSET_PARAMETER)) //$NON-NLS-1$
- .withParameter(LIMIT_PARAMETER, limit)
- .withParameter(OFFSET_PARAMETER, offset)
+ String mapKey1 = formatParameterMapKey(LIMIT_PARAMETER);
+ String mapKey2 = formatParameterMapKey(OFFSET_PARAMETER);
+ return FragmentAndParameters.withFragment("limit " + renderPlaceholder(mapKey1) //$NON-NLS-1$
+ + " offset " + renderPlaceholder(mapKey2)) //$NON-NLS-1$
+ .withParameter(mapKey1, limit)
+ .withParameter(mapKey2, offset)
.buildOptional();
}
-
+
+ private String formatParameterMapKey(String parameterMapKey) {
+ return parameterMapKey + sequence.getAndIncrement(); //$NON-NLS-1$
+ }
+
private String renderPlaceholder(String parameterName) {
return renderingStrategy.getFormattedJdbcPlaceholder(RenderingStrategy.DEFAULT_PARAMETER_PREFIX,
- parameterName);
+ parameterName);
}
}
diff --git a/src/main/java/org/mybatis/dynamic/sql/select/render/PagingModelRenderer.java b/src/main/java/org/mybatis/dynamic/sql/select/render/PagingModelRenderer.java
index 7161d5742..65df4b7fc 100644
--- a/src/main/java/org/mybatis/dynamic/sql/select/render/PagingModelRenderer.java
+++ b/src/main/java/org/mybatis/dynamic/sql/select/render/PagingModelRenderer.java
@@ -1,22 +1,23 @@
/**
- * Copyright 2016-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Copyright 2016-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.mybatis.dynamic.sql.select.render;
import java.util.Objects;
import java.util.Optional;
+import java.util.concurrent.atomic.AtomicInteger;
import org.mybatis.dynamic.sql.render.RenderingStrategy;
import org.mybatis.dynamic.sql.select.PagingModel;
@@ -25,30 +26,33 @@
public class PagingModelRenderer {
private RenderingStrategy renderingStrategy;
private PagingModel pagingModel;
+ private AtomicInteger sequence;
private PagingModelRenderer(Builder builder) {
renderingStrategy = Objects.requireNonNull(builder.renderingStrategy);
pagingModel = Objects.requireNonNull(builder.pagingModel);
+ sequence = Objects.requireNonNull(builder.sequence);
}
-
+
public Optional render() {
return pagingModel.limit().map(this::limitAndOffsetRender)
.orElseGet(this::fetchFirstRender);
}
-
+
private Optional limitAndOffsetRender(Long limit) {
return new LimitAndOffsetPagingModelRenderer(renderingStrategy, limit,
- pagingModel).render();
+ pagingModel, sequence).render();
}
-
+
private Optional fetchFirstRender() {
- return new FetchFirstPagingModelRenderer(renderingStrategy, pagingModel).render();
+ return new FetchFirstPagingModelRenderer(renderingStrategy, pagingModel, sequence).render();
}
-
+
public static class Builder {
private RenderingStrategy renderingStrategy;
private PagingModel pagingModel;
-
+ private AtomicInteger sequence;
+
public Builder withRenderingStrategy(RenderingStrategy renderingStrategy) {
this.renderingStrategy = renderingStrategy;
return this;
@@ -58,7 +62,12 @@ public Builder withPagingModel(PagingModel pagingModel) {
this.pagingModel = pagingModel;
return this;
}
-
+
+ public Builder withSequence(AtomicInteger sequence) {
+ this.sequence = sequence;
+ return this;
+ }
+
public PagingModelRenderer build() {
return new PagingModelRenderer(this);
}
diff --git a/src/main/java/org/mybatis/dynamic/sql/select/render/SelectRenderer.java b/src/main/java/org/mybatis/dynamic/sql/select/render/SelectRenderer.java
index 0a54fdfcf..b65318897 100644
--- a/src/main/java/org/mybatis/dynamic/sql/select/render/SelectRenderer.java
+++ b/src/main/java/org/mybatis/dynamic/sql/select/render/SelectRenderer.java
@@ -1,17 +1,17 @@
/**
- * Copyright 2016-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
+ * Copyright 2016-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
*/
package org.mybatis.dynamic.sql.select.render;
@@ -34,22 +34,22 @@ public class SelectRenderer {
private SelectModel selectModel;
private RenderingStrategy renderingStrategy;
private AtomicInteger sequence;
-
+
private SelectRenderer(Builder builder) {
selectModel = Objects.requireNonNull(builder.selectModel);
renderingStrategy = Objects.requireNonNull(builder.renderingStrategy);
sequence = builder.sequence().orElseGet(() -> new AtomicInteger(1));
}
-
+
public SelectStatementProvider render() {
FragmentCollector fragmentCollector = selectModel
.mapQueryExpressions(this::renderQueryExpression)
.collect(FragmentCollector.collect());
renderOrderBy(fragmentCollector);
renderPagingModel(fragmentCollector);
-
+
String selectStatement = fragmentCollector.fragments().collect(Collectors.joining(" ")); //$NON-NLS-1$
-
+
return DefaultSelectStatementProvider.withSelectStatement(selectStatement)
.withParameters(fragmentCollector.parameters())
.build();
@@ -66,13 +66,13 @@ private FragmentAndParameters renderQueryExpression(QueryExpressionModel queryEx
private void renderOrderBy(FragmentCollector fragmentCollector) {
selectModel.orderByModel().ifPresent(om -> renderOrderBy(fragmentCollector, om));
}
-
+
private void renderOrderBy(FragmentCollector fragmentCollector, OrderByModel orderByModel) {
String phrase = orderByModel.mapColumns(this::calculateOrderByPhrase)
.collect(CustomCollectors.joining(", ", "order by ", "")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
fragmentCollector.add(FragmentAndParameters.withFragment(phrase).build());
}
-
+
private String calculateOrderByPhrase(SortSpecification column) {
String phrase = column.aliasOrName();
if (column.isDescending()) {
@@ -80,16 +80,17 @@ private String calculateOrderByPhrase(SortSpecification column) {
}
return phrase;
}
-
+
private void renderPagingModel(FragmentCollector fragmentCollector) {
selectModel.pagingModel().flatMap(this::renderPagingModel)
- .ifPresent(fragmentCollector::add);
+ .ifPresent(fragmentCollector::add);
}
-
+
private Optional renderPagingModel(PagingModel pagingModel) {
return new PagingModelRenderer.Builder()
.withPagingModel(pagingModel)
.withRenderingStrategy(renderingStrategy)
+ .withSequence(sequence)
.build()
.render();
}
@@ -97,31 +98,31 @@ private Optional renderPagingModel(PagingModel pagingMode
public static Builder withSelectModel(SelectModel selectModel) {
return new Builder().withSelectModel(selectModel);
}
-
+
public static class Builder {
private SelectModel selectModel;
private RenderingStrategy renderingStrategy;
private AtomicInteger sequence;
-
+
public Builder withSelectModel(SelectModel selectModel) {
this.selectModel = selectModel;
return this;
}
-
+
public Builder withRenderingStrategy(RenderingStrategy renderingStrategy) {
this.renderingStrategy = renderingStrategy;
return this;
}
-
+
public Builder withSequence(AtomicInteger sequence) {
this.sequence = sequence;
return this;
}
-
+
private Optional sequence() {
return Optional.ofNullable(sequence);
}
-
+
public SelectRenderer build() {
return new SelectRenderer(this);
}
diff --git a/src/test/java/examples/animal/data/FetchFirstTest.java b/src/test/java/examples/animal/data/FetchFirstTest.java
index 9ac7ee84d..9d3b4a791 100644
--- a/src/test/java/examples/animal/data/FetchFirstTest.java
+++ b/src/test/java/examples/animal/data/FetchFirstTest.java
@@ -79,9 +79,9 @@ public void testOffsetAndFetchFirstAfterFrom() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(23),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData offset #{parameters._offset} rows fetch first #{parameters._fetchFirstRows} rows only"),
- () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(3L),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData offset #{parameters._offset1} rows fetch first #{parameters._fetchFirstRows2} rows only"),
+ () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows2")).isEqualTo(3L),
+ () -> assertThat(selectStatement.getParameters().get("_offset1")).isEqualTo(22L)
);
}
}
@@ -101,8 +101,8 @@ public void testFetchFirstOnlyAfterFrom() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(1),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData fetch first #{parameters._fetchFirstRows} rows only"),
- () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(3L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData fetch first #{parameters._fetchFirstRows1} rows only"),
+ () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows1")).isEqualTo(3L)
);
}
}
@@ -125,9 +125,9 @@ public void testOffsetAndFetchFirstAfterWhere() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(45),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} and id > #{parameters.p2,jdbcType=INTEGER} offset #{parameters._offset} rows fetch first #{parameters._fetchFirstRows} rows only"),
- () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(3L),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} and id > #{parameters.p2,jdbcType=INTEGER} offset #{parameters._offset3} rows fetch first #{parameters._fetchFirstRows4} rows only"),
+ () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows4")).isEqualTo(3L),
+ () -> assertThat(selectStatement.getParameters().get("_offset3")).isEqualTo(22L)
);
}
}
@@ -148,8 +148,8 @@ public void testFetchFirstOnlyAfterWhere() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(1),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} fetch first #{parameters._fetchFirstRows} rows only"),
- () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(3L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} fetch first #{parameters._fetchFirstRows2} rows only"),
+ () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows2")).isEqualTo(3L)
);
}
}
@@ -171,9 +171,9 @@ public void testOffsetAndFetchFirstAfterOrderBy() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(23),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id offset #{parameters._offset} rows fetch first #{parameters._fetchFirstRows} rows only"),
- () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(3L),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id offset #{parameters._offset1} rows fetch first #{parameters._fetchFirstRows2} rows only"),
+ () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows2")).isEqualTo(3L),
+ () -> assertThat(selectStatement.getParameters().get("_offset1")).isEqualTo(22L)
);
}
}
@@ -194,8 +194,8 @@ public void testLimitOnlyAfterOrderBy() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(1),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id fetch first #{parameters._fetchFirstRows} rows only"),
- () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(3L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id fetch first #{parameters._fetchFirstRows1} rows only"),
+ () -> assertThat(selectStatement.getParameters().get("_fetchFirstRows1")).isEqualTo(3L)
);
}
}
diff --git a/src/test/java/examples/animal/data/LimitAndOffsetTest.java b/src/test/java/examples/animal/data/LimitAndOffsetTest.java
index 1251c2a09..e1896ffc9 100644
--- a/src/test/java/examples/animal/data/LimitAndOffsetTest.java
+++ b/src/test/java/examples/animal/data/LimitAndOffsetTest.java
@@ -79,9 +79,9 @@ public void testLimitAndOffsetAfterFrom() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(23),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData limit #{parameters._limit} offset #{parameters._offset}"),
- () -> assertThat(selectStatement.getParameters().get("_limit")).isEqualTo(3L),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData limit #{parameters._limit1} offset #{parameters._offset2}"),
+ () -> assertThat(selectStatement.getParameters().get("_limit1")).isEqualTo(3L),
+ () -> assertThat(selectStatement.getParameters().get("_offset2")).isEqualTo(22L)
);
}
}
@@ -101,8 +101,8 @@ public void testLimitOnlyAfterFrom() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(1),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData limit #{parameters._limit}"),
- () -> assertThat(selectStatement.getParameters().get("_limit")).isEqualTo(3L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData limit #{parameters._limit1}"),
+ () -> assertThat(selectStatement.getParameters().get("_limit1")).isEqualTo(3L)
);
}
}
@@ -122,8 +122,8 @@ public void testOffsetOnlyAfterFrom() {
assertAll(
() -> assertThat(records.size()).isEqualTo(43),
() -> assertThat(records.get(0).getId()).isEqualTo(23),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData offset #{parameters._offset} rows"),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData offset #{parameters._offset1} rows"),
+ () -> assertThat(selectStatement.getParameters().get("_offset1")).isEqualTo(22L)
);
}
}
@@ -146,9 +146,9 @@ public void testLimitAndOffsetAfterWhere() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(45),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} and id > #{parameters.p2,jdbcType=INTEGER} limit #{parameters._limit} offset #{parameters._offset}"),
- () -> assertThat(selectStatement.getParameters().get("_limit")).isEqualTo(3L),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} and id > #{parameters.p2,jdbcType=INTEGER} limit #{parameters._limit3} offset #{parameters._offset4}"),
+ () -> assertThat(selectStatement.getParameters().get("_limit3")).isEqualTo(3L),
+ () -> assertThat(selectStatement.getParameters().get("_offset4")).isEqualTo(22L)
);
}
}
@@ -169,8 +169,8 @@ public void testLimitOnlyAfterWhere() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(1),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} limit #{parameters._limit}"),
- () -> assertThat(selectStatement.getParameters().get("_limit")).isEqualTo(3L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} limit #{parameters._limit2}"),
+ () -> assertThat(selectStatement.getParameters().get("_limit2")).isEqualTo(3L)
);
}
}
@@ -191,8 +191,8 @@ public void testOffsetOnlyAfterWhere() {
assertAll(
() -> assertThat(records.size()).isEqualTo(27),
() -> assertThat(records.get(0).getId()).isEqualTo(23),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} offset #{parameters._offset} rows"),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData where id < #{parameters.p1,jdbcType=INTEGER} offset #{parameters._offset2} rows"),
+ () -> assertThat(selectStatement.getParameters().get("_offset2")).isEqualTo(22L)
);
}
}
@@ -214,9 +214,9 @@ public void testLimitAndOffsetAfterOrderBy() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(23),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id limit #{parameters._limit} offset #{parameters._offset}"),
- () -> assertThat(selectStatement.getParameters().get("_limit")).isEqualTo(3L),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id limit #{parameters._limit1} offset #{parameters._offset2}"),
+ () -> assertThat(selectStatement.getParameters().get("_limit1")).isEqualTo(3L),
+ () -> assertThat(selectStatement.getParameters().get("_offset2")).isEqualTo(22L)
);
}
}
@@ -237,8 +237,8 @@ public void testLimitOnlyAfterOrderBy() {
assertAll(
() -> assertThat(records.size()).isEqualTo(3),
() -> assertThat(records.get(0).getId()).isEqualTo(1),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id limit #{parameters._limit}"),
- () -> assertThat(selectStatement.getParameters().get("_limit")).isEqualTo(3L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id limit #{parameters._limit1}"),
+ () -> assertThat(selectStatement.getParameters().get("_limit1")).isEqualTo(3L)
);
}
}
@@ -259,8 +259,8 @@ public void testOffsetOnlyAfterOrderBy() {
assertAll(
() -> assertThat(records.size()).isEqualTo(43),
() -> assertThat(records.get(0).getId()).isEqualTo(23),
- () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id offset #{parameters._offset} rows"),
- () -> assertThat(selectStatement.getParameters().get("_offset")).isEqualTo(22L)
+ () -> assertThat(selectStatement.getSelectStatement()).isEqualTo("select * from AnimalData order by id offset #{parameters._offset1} rows"),
+ () -> assertThat(selectStatement.getParameters().get("_offset1")).isEqualTo(22L)
);
}
}
diff --git a/src/test/java/examples/complexquery/ComplexQueryTest.java b/src/test/java/examples/complexquery/ComplexQueryTest.java
index d159a686d..4bcd9748d 100644
--- a/src/test/java/examples/complexquery/ComplexQueryTest.java
+++ b/src/test/java/examples/complexquery/ComplexQueryTest.java
@@ -40,11 +40,11 @@ public void testId() {
+ " from Person"
+ " where person_id = #{parameters.p1}"
+ " order by last_name, first_name"
- + " fetch first #{parameters._fetchFirstRows} rows only";
+ + " fetch first #{parameters._fetchFirstRows2} rows only";
assertThat(selectStatement.getSelectStatement()).isEqualTo(expected);
assertThat(selectStatement.getParameters().get("p1")).isEqualTo(2);
- assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(50L);
+ assertThat(selectStatement.getParameters().get("_fetchFirstRows2")).isEqualTo(50L);
}
@Test
@@ -55,11 +55,11 @@ public void testFirstNameOnly() {
+ " from Person"
+ " where first_name like #{parameters.p1}"
+ " order by last_name, first_name"
- + " fetch first #{parameters._fetchFirstRows} rows only";
+ + " fetch first #{parameters._fetchFirstRows2} rows only";
assertThat(selectStatement.getSelectStatement()).isEqualTo(expected);
assertThat(selectStatement.getParameters().get("p1")).isEqualTo("%fred%");
- assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(50L);
+ assertThat(selectStatement.getParameters().get("_fetchFirstRows2")).isEqualTo(50L);
}
@Test
@@ -70,11 +70,11 @@ public void testLastNameOnly() {
+ " from Person"
+ " where last_name like #{parameters.p1}"
+ " order by last_name, first_name"
- + " fetch first #{parameters._fetchFirstRows} rows only";
+ + " fetch first #{parameters._fetchFirstRows2} rows only";
assertThat(selectStatement.getSelectStatement()).isEqualTo(expected);
assertThat(selectStatement.getParameters().get("p1")).isEqualTo("%flintstone%");
- assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(50L);
+ assertThat(selectStatement.getParameters().get("_fetchFirstRows2")).isEqualTo(50L);
}
@Test
@@ -86,12 +86,12 @@ public void testBothNames() {
+ " where first_name like #{parameters.p1}"
+ " and last_name like #{parameters.p2}"
+ " order by last_name, first_name"
- + " fetch first #{parameters._fetchFirstRows} rows only";
+ + " fetch first #{parameters._fetchFirstRows3} rows only";
assertThat(selectStatement.getSelectStatement()).isEqualTo(expected);
assertThat(selectStatement.getParameters().get("p1")).isEqualTo("%fred%");
assertThat(selectStatement.getParameters().get("p2")).isEqualTo("%flintstone%");
- assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(50L);
+ assertThat(selectStatement.getParameters().get("_fetchFirstRows3")).isEqualTo(50L);
}
@Test
@@ -101,10 +101,10 @@ public void testAllNull() {
String expected = "select person_id, first_name, last_name"
+ " from Person"
+ " order by last_name, first_name"
- + " fetch first #{parameters._fetchFirstRows} rows only";
+ + " fetch first #{parameters._fetchFirstRows1} rows only";
assertThat(selectStatement.getSelectStatement()).isEqualTo(expected);
- assertThat(selectStatement.getParameters().get("_fetchFirstRows")).isEqualTo(50L);
+ assertThat(selectStatement.getParameters().get("_fetchFirstRows1")).isEqualTo(50L);
}
public SelectStatementProvider search(Integer targetId, String fName, String lName) {
diff --git a/src/test/java/examples/groupby/GroupByTest.java b/src/test/java/examples/groupby/GroupByTest.java
index 08c51f685..c41231c6c 100644
--- a/src/test/java/examples/groupby/GroupByTest.java
+++ b/src/test/java/examples/groupby/GroupByTest.java
@@ -401,7 +401,7 @@ public void testLimitAndOffsetAfterGroupBy() {
.build()
.render(RenderingStrategies.MYBATIS3);
- String expected = "select last_name, count(*) as count from Person group by last_name limit #{parameters._limit} offset #{parameters._offset}";
+ String expected = "select last_name, count(*) as count from Person group by last_name limit #{parameters._limit1} offset #{parameters._offset2}";
assertThat(selectStatement.getSelectStatement()).isEqualTo(expected);
List