refactor: start converting thiserror to snafu

Author: “ramfox”

Cargo.lock

@@ -11,11 +11,13 @@ derive_more = { version = "2.0.1", features = ["from", "try_from", "into", "debu
 futures-lite = "2.6.0"
 quinn = { package = "iroh-quinn", version = "0.13.0" }
 n0-future = "0.1.2"
+n0-snafu = "0.2.0"
 n0-watcher = "0.2.0"
+nested_enum_utils = "0.2.1"
 range-collections = { version = "0.4.6", features = ["serde"] }
 redb = "2.4.0"
 smallvec = { version = "1", features = ["serde", "const_new"] }
-thiserror = "2.0.11"
+snafu = "0.8.5"
 tokio = { version = "1.43.0", features = ["full"] }
 tokio-util = { version = "0.7.13", features = ["full"] }
 tracing = "0.1.41"

Cargo.toml

@@ -243,23 +243,33 @@ pub mod fsm {
     }
 
     /// Error that you can get from [`AtConnected::next`]
-    #[derive(Debug, thiserror::Error)]
+    #[common_fields({
+    backtrace: Option<Backtrace>,
+    #[snafu(implicit)]
+    span_trace: n0_snafu::SpanTrace,
+})]
+    #[allow(missing_docs)]
+    #[derive(Debug, Snafu)]
+    #[non_exhaustive]
+    #[derive(Debug, snafu::Error)]
     pub enum ConnectedNextError {
         /// Error when serializing the request
-        #[error("postcard ser: {0}")]
-        PostcardSer(postcard::Error),
+        #[snafu(display("postcard ser: {source}"))]
+        PostcardSer { source: postcard::Error },
         /// The serialized request is too long to be sent
-        #[error("request too big")]
+        #[snafu(display("request too big"))]
         RequestTooBig,
         /// Error when writing the request to the [`SendStream`].
-        #[error("write: {0}")]
-        Write(#[from] iroh::endpoint::WriteError),
+        #[snafu(display("write: {source}"))]
+        Write { source: iroh::endpoint::WriteError },
         /// Quic connection is closed.
-        #[error("closed")]
-        Closed(#[from] quinn::ClosedStream),
+        #[snafu(display("closed"))]
+        Closed {
+            source: iroh::endpoint::ClosedStream,
+        },
         /// A generic io error
-        #[error("io {0}")]
-        Io(io::Error),
+        #[snafu(transparent)]
+        Io { source: io::Error },
     }
 
     impl ConnectedNextError {

src/get.rs

@@ -11,7 +11,10 @@ use std::{
 use bao_tree::BaoTree;
 use bytes::Bytes;
 use irpc::channel::spsc;
+use n0_snafu::SpanTrace;
+use nested_enum_utils::common_fields;
 use redb::{Database, DatabaseError, ReadableTable};
+use snafu::{Backtrace, Snafu};
 use tokio::pin;
 
 use crate::{
@@ -46,21 +49,28 @@ use crate::store::{Hash, IROH_BLOCK_SIZE, util::Tag};
 ///
 /// What can go wrong are various things with redb, as well as io errors related
 /// to files other than redb.
-#[allow(clippy::large_enum_variant)]
-#[derive(Debug, thiserror::Error)]
+#[common_fields({
+    backtrace: Option<Backtrace>,
+    #[snafu(implicit)]
+    span_trace: n0_snafu::SpanTrace,
+})]
+#[allow(missing_docs)]
+#[derive(Debug, Snafu)]
+#[non_exhaustive]
+#[derive(Debug, snafu::Error)]
 pub enum ActorError {
-    #[error("table error: {0}")]
-    Table(#[from] redb::TableError),
-    #[error("database error: {0}")]
-    Database(#[from] redb::DatabaseError),
-    #[error("transaction error: {0}")]
-    Transaction(#[from] redb::TransactionError),
-    #[error("commit error: {0}")]
-    Commit(#[from] redb::CommitError),
-    #[error("storage error: {0}")]
-    Storage(#[from] redb::StorageError),
-    #[error("inconsistent database state: {0}")]
-    Inconsistent(String),
+    #[snafu(display("table error: {source}"))]
+    Table { source: redb::TableError },
+    #[snafu(display("database error: {source}"))]
+    Database { source: redb::DatabaseError },
+    #[snafu(display("transaction error: {source}"))]
+    Transaction { source: redb::TransactionError },
+    #[snafu(display("commit error: {source}"))]
+    Commit { source: redb::CommitError },
+    #[snafu(display("storage error: {source}"))]
+    Storage { source: redb::StorageError },
+    #[snafu(display("inconsistent database state: {source}"))]
+    Inconsistent { source: String },
 }
 
 impl From<ActorError> for io::Error {