Skip to content

A fix for OnDragLeave causing a flickering affect #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2015

Conversation

rylan
Copy link
Contributor

@rylan rylan commented Oct 28, 2014

Fixed flickering effect being caused with the addition and removal of the overclass on drag. When OnDragLeave event triggers the logic should be if the two elements are not the same remove the over class, otherwise return.

Fixed flickering effect being caused with the addition and removal of the overclass on drag. When OnDragLeave event triggers the logic should be if the two elements are not the same remove the over class, otherwise return.
@rylan rylan changed the title Update module.js A fix for OnDragLeave causing a flickering affect Oct 30, 2014
@klauspost
Copy link

It does fix the flicker for me, but unfortunately the overlay is no longer removed if you take the drop outside the browser window.

@rylan
Copy link
Contributor Author

rylan commented Nov 5, 2014

@klauspost is the browser window the entire drop target? does it happen in all browsers?

@klauspost
Copy link

At least in Chrome. The easiest way to reproduce is to set the entire browser window as a drop target.

@rylan
Copy link
Contributor Author

rylan commented Nov 5, 2014

looks like we just need to add a handler for drag end event to capture that case. Added the event handler give it a try.

@rylan
Copy link
Contributor Author

rylan commented Nov 10, 2014

@nervgh any chance of getting this reviewed and merged in the near future?

@rylan
Copy link
Contributor Author

rylan commented Nov 10, 2014

@klauspost I revert the onDragEnd work I added, because it presented issues with multiple drop targets on a page.

@nervgh nervgh merged commit bd1bc4e into nervgh:master Jul 28, 2015
@nervgh
Copy link
Owner

nervgh commented Jul 28, 2015

Fixed 9c584b2. Thanks, guys 👍

nervgh added a commit that referenced this pull request Jul 28, 2015
nervgh added a commit that referenced this pull request Aug 2, 2015
nervgh added a commit that referenced this pull request Aug 10, 2015
(cherry picked from commit 73903b1)

Conflicts:
	dist/angular-file-upload.min.js
	package.json
@jackhsu978
Copy link

@rylan I have the same issue as @klauspost. The overclass is no longer removed when I drop outside of the target. It happens for me on Chrome, Firefox, and Safari.

@Falldog
Copy link

Falldog commented Dec 21, 2015

@jackhsu978 me too

@jackhsu978
Copy link

@Falldog you may be interested in this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants