Add failsafe to avoid flickering due to spurious out events #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On certain pages I actually get more out events than I do over events; drop still works fine, but I get lots of flickering on the page. With this change as long as those events aren't slower than 50ms it doesn't happen, but 50ms is still short enough it's not really noticeable.
|
fixed #286 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fought with this for a couple of hours to find a cleaner fix, but this seems to be the best option. There are actually some browsers (Chrome and Safari on Mac specifically) where in some cases I received dragleave events more frequently than dragover events.
drop still works fine, but I get lots of flickering on the page. With
this change as long as those events aren't slower than 50ms it doesn't
happen, but 50ms is still short enough it's not really noticeable.