Closes #19893: Include hostname in REST API status endpoint #19895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested review from
a team and
bctiemann
and removed request for
a team
jnovinger
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Two quick thoughts for follow-up:
- Since we don't actually document the /api/status/ endpoint anywhere (which hasn't been a problem), maybe we should file a housekeeping ticket to add it to the API schema? Would help all the existing fields too.
- Also worth considering a simple test for this - even though it's straightforward, having automated coverage for API fields helps catch regressions without relying on manual checks during releases.
Both are follow-up items though - this is ready to ship as-is!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #19893
Include the system hostname in REST API status output.