Skip to content

Closes #19893: Include hostname in REST API status endpoint #19895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

jeremystretch
Copy link
Member

Closes: #19893

Include the system hostname in REST API status output.

@jeremystretch jeremystretch requested review from a team and bctiemann and removed request for a team July 16, 2025 14:30
@jeremystretch jeremystretch requested review from jnovinger and removed request for bctiemann July 24, 2025 14:42
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick thoughts for follow-up:

  • Since we don't actually document the /api/status/ endpoint anywhere (which hasn't been a problem), maybe we should file a housekeeping ticket to add it to the API schema? Would help all the existing fields too.
  • Also worth considering a simple test for this - even though it's straightforward, having automated coverage for API fields helps catch regressions without relying on manual checks during releases.

Both are follow-up items though - this is ready to ship as-is!

@jnovinger jnovinger merged commit c047f35 into feature Jul 24, 2025
6 checks passed
@jnovinger jnovinger deleted the 19893-api-status-hostname branch July 24, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants