Skip to content

Commit f6a2982

Browse files
committed
Add some comments
1 parent b26d9b7 commit f6a2982

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

internal/controller/nginx/config/servers.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,8 @@ func createLocations(
280280

281281
mirrorPercentage, exists := mirrorPathToPercentage[rule.Path]
282282
if !exists {
283+
// need a way to differentiate between no mirror filter and a mirror filter with 0 percent set, and
284+
// I don't want to pass an extra boolean around.
283285
mirrorPercentage = -1
284286
}
285287

internal/controller/state/dataplane/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ type HTTPRequestMirrorFilter struct {
215215
Name *string
216216
// Namespace is the namespace of the service.
217217
Namespace *string
218-
// Target is the target of the mirror (path with hostname, service name and route NamespacedName).
218+
// Target is the target of the mirror (path with hostname, service name, and route NamespacedName).
219219
Target *string
220220
// Percent is the percentage of requests to mirror.
221221
Percent *float64

0 commit comments

Comments
 (0)