-
Notifications
You must be signed in to change notification settings - Fork 130
Add support for percentage based request mirroring #3627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8248ac9
to
f6a2982
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3627 +/- ##
==========================================
+ Coverage 86.91% 87.06% +0.14%
==========================================
Files 127 127
Lines 15287 15471 +184
Branches 62 62
==========================================
+ Hits 13287 13470 +183
Misses 1847 1847
- Partials 153 154 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewing is harder than I thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
This reverts commit 0b6afd8.
e13d020
to
27e033e
Compare
Proposed changes
Add support for percentage based request mirroring by supporting the percent and fraction fields in the HTTPRequestMirrorFilter API.
Problem: Users would like to enable percentage based request mirroring.
Solution: Add support for the percent and fraction fields in the HTTPRequestMirrorFilter API.
Testing: Added unit tests, updated conformance tests run, manually ran these test cases:
Closes #3314
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.