From 3d9f7e8b629468b7632c101d0af08b951b43f1ee Mon Sep 17 00:00:00 2001 From: Steve Wagner Date: Mon, 27 Nov 2023 15:15:49 -0800 Subject: [PATCH] Rename arguments for clarity and ensure correct usage --- internal/certification/certificates.go | 2 +- internal/configuration/settings.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/certification/certificates.go b/internal/certification/certificates.go index 6595cf9e..ac31702f 100644 --- a/internal/certification/certificates.go +++ b/internal/certification/certificates.go @@ -176,7 +176,7 @@ func (c *Certificates) handleDeleteEvent(obj interface{}) { logrus.Debugf("Certificates::handleDeleteEvent: certificates (%d)", len(c.Certificates)) } -func (c *Certificates) handleUpdateEvent(oldValue interface{}, newValue interface{}) { +func (c *Certificates) handleUpdateEvent(_ interface{}, newValue interface{}) { logrus.Debug("Certificates::handleUpdateEvent") secret, ok := newValue.(*corev1.Secret) diff --git a/internal/configuration/settings.go b/internal/configuration/settings.go index 3c2715b1..624dfbc8 100644 --- a/internal/configuration/settings.go +++ b/internal/configuration/settings.go @@ -266,10 +266,10 @@ func (s *Settings) handleDeleteEvent(obj interface{}) { } } -func (s *Settings) handleUpdateEvent(_ interface{}, obj interface{}) { +func (s *Settings) handleUpdateEvent(_ interface{}, newValue interface{}) { logrus.Debug("Settings::handleUpdateEvent") - configMap, yes := isOurConfig(obj) + configMap, yes := isOurConfig(newValue) if !yes { return }