Skip to content

docs: update nodejs versions to 22 in README.md #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mertssmnoglu
Copy link
Contributor

@mertssmnoglu mertssmnoglu commented May 30, 2025

Description

Updated node:8 and node:16 image tags to node:22 in README. Update docker-compose example.

Motivation and Context

As a developer, I would like to see latest LTS version in the documentation.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@mertssmnoglu
Copy link
Contributor Author

mertssmnoglu commented May 30, 2025

I'm also thinking about updating docker compose example too. Is it OK to do it in this PR?

services:
  node:
    image: "node:22"
    environment:
      - NODE_ENV=production
    volumes:
      - ./:/home/node/app
    ports: # use if it is necessary to expose the container to the host machine
      - "8081:8081"
    command: ["npm", "start"]

@SimenB
Copy link
Member

SimenB commented Jul 16, 2025

I'm also thinking about updating docker compose example too. Is it OK to do it in this PR?

services:
  node:
    image: "node:22"
    environment:
      - NODE_ENV=production
    volumes:
      - ./:/home/node/app
    ports: # use if it is necessary to expose the container to the host machine
      - "8081:8081"
    command: ["npm", "start"]

Yes please 🙂

@mertssmnoglu mertssmnoglu marked this pull request as ready for review July 24, 2025 10:23
@mertssmnoglu mertssmnoglu force-pushed the readme-node-version branch from 84f117e to d9df67d Compare July 24, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants