Skip to content

Handle sparse data #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2021
Merged

Handle sparse data #169

merged 3 commits into from
Sep 14, 2021

Conversation

visnup
Copy link
Member

@visnup visnup commented Sep 10, 2021 •
edited
Loading

Renders empty rows for sparse or falsey nullish rows. Still allows them to be selected.

Also, I found a missing exported test for selectWide which I've included.

@visnup visnup requested review from Fil and mbostock September 10, 2021 21:50
@visnup visnup mentioned this pull request Sep 10, 2021
Merged
5 tasks
mbostock
mbostock requested changes Sep 10, 2021
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should limit this behavior to nullish rather than falsey.

Thanks for improving the tests.

@visnup visnup merged commit 92126e9 into main Sep 14, 2021
@visnup visnup deleted the visnup/table-sparse branch September 14, 2021 15:51
@visnup visnup mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visnup @Fil @mbostock