[ADD] estate: add unit tests for property business logic

- Introduced new unit tests in the estate module covering key business processes:
  - Prevent offer creation on sold properties.
  - Disallow marking properties as sold without an accepted offer.
  - Ensure garden area and orientation fields reset appropriately when garden is unchecked.
- These tests improve the reliability and maintainability of the estate workflow.

Author: zadh-odoo

estate/models/estate_property.py

@@ -83,14 +83,15 @@ def _onchange_garden(self):
                 record.garden_orientation = "north"
             else:
                 record.garden_area = 0
-                record.garden_orientation = ""
+                record.garden_orientation = False
 
     def action_set_state_sold(self):
         for record in self:
             if record.state == "cancelled":
                 raise UserError(_("Cancelled property cannot be sold."))
-            else:
-                record.state = "sold"
+            if not record.offer_ids.filtered(lambda o: o.status == "accepted"):
+                raise UserError(_("You cannot sell a property without an accepted offer."))
+            record.state = "sold"
         return True
 
     def action_set_state_cancel(self):

estate/models/estate_property_offer.py

@@ -1,5 +1,5 @@
 from odoo import fields, models, api, _
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
 from datetime import timedelta, datetime
 
 
@@ -31,10 +31,8 @@ def create(self, vals):
         for val in vals:
             property_id = val["property_id"]
             offer_price = val["price"]
-            is_state_new = (
-                self.env["estate.property"].browse(property_id).state == "new"
-            )
-
+            property = self.env["estate.property"].browse(property_id)
+            is_state_new = (property.state == "new")
             result = self.read_group(
                 domain=[("property_id", "=", property_id)],
                 fields=["price:max"],
@@ -43,11 +41,14 @@ def create(self, vals):
 
             max_price = result[0]["price"] if result else 0
 
+            if property.state == 'sold':
+                raise ValidationError(_("Cannot create an offer on a sold property."))
+
             if max_price >= offer_price:
                 raise UserError(_("You cannot create an offer with a lower or equal amount than an existing offer for this property."))
 
             if is_state_new:
-                self.env["estate.property"].browse(property_id).state = "offer_received"
+                property.state = "offer_received"
 
         return super().create(vals)
 

estate/tests/__init__.py

@@ -0,0 +1,3 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import test_estate_property_offer

estate/tests/test_estate_property_offer.py

@@ -0,0 +1,59 @@
+from odoo.exceptions import ValidationError, UserError
+from odoo.tests import Form, tagged
+from odoo.tests.common import TransactionCase 
+
+
+@tagged('post_install', '-at_install')
+class TestEstateProperty(TransactionCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.partner = cls.env["res.partner"].create({"name": "Test Buyer"}) 
+        cls.property_type = cls.env["estate.property.types"].create({"name": "Apartment2"})
+        cls.property = cls.env["estate.property"].create({
+            "name": "Test Property",
+            "expected_price": 150000,
+            "property_type_id": cls.property_type.id 
+        })
+    
+    def test_cannot_create_offer_on_sold_property(self):
+        self.property.state = "sold"
+        with self.assertRaises(ValidationError):
+            self.env["estate.property.offer"].create({
+                "price": 160000,
+                "partner_id": self.partner.id,
+                "property_id": self.property.id
+            })
+    
+    def test_cannot_sell_property_without_accepted_offer(self):
+        with self.assertRaises(UserError):
+            self.property.action_set_state_sold()
+
+    def test_cannot_sell_property_with_accepted_offer(self):
+        offer = self.env["estate.property.offer"].create({
+            "price": 160000,
+            "partner_id": self.partner.id,
+            "property_id": self.property.id
+        })
+        offer.action_accept_offer()
+        self.property.action_set_state_sold()
+        self.assertEqual(self.property.state, "sold")
+        self.assertEqual(self.property.selling_price, offer.price)
+        self.assertEqual(self.property.buyer_id, self.partner)
+
+    def test_garden_fields_reset_on_uncheck(self):
+        with Form(self.env["estate.property"]) as prop:
+            prop.expected_price = 10000
+            prop.name = "Test property"
+            prop.garden = True
+            prop.garden_area = 25
+            prop.garden_orientation = "west"
+        property = prop.save()
+
+        with Form(property) as prop:
+            prop.garden = False
+        property = prop.save()
+
+        self.assertEqual(property.garden_area, 0)
+        self.assertFalse(property.garden_orientation)