[IMP] real_estate: added test cases for offer validation and garden toggle

- Prevented new offers from being submitted on properties that are already sold.
- Fixed the garden toggle so that when it’s unchecked, related fields like area
  and orientation are cleared.
- Added test cases to verify offer restrictions and garden field behavior.

Author: prbo-odoo

estate_account/models/estate_property.py

@@ -6,8 +6,7 @@ class EstateProperty(models.Model):
     _inherit = "estate.property"
 
     def action_sold(self):
-        self.check_access_rights('write')
-        self.check_access_rule('write')
+        self.check_access('write')
         journal = self.env['account.journal'].sudo().search([
             ('type', '=', 'sale'),
         ], limit=1)

real_estate/demo/demo_data.xml

@@ -34,7 +34,7 @@
     <record id="offer_azure_accepted" model="estate.property.offer">
         <field name="partner_id" ref="base.res_partner_1" />
         <field name="property_id" ref="estate_demo_property" />
-        <field name="price">90000</field>
+        <field name="price">98000</field>
         <field name="validity">14</field>
         <field name="date_deadline" eval="(datetime.now() + timedelta(days=14)).date().isoformat()" />
     </record>

real_estate/models/estate_property.py

@@ -85,11 +85,14 @@ def _onchange_garden(self):
             self.garden_orientation = False
 
     def action_sold(self):
+        self.check_access('write')
         for record in self:
-            if record.state in ['sold', 'cancelled']:
-                raise UserError("You cannot sell a cancelled or already sold property.")
-            if not record.buyer:
-                raise UserError("Please assign a buyer before marking the property as sold.")
+            if record.state == 'cancelled':
+                raise UserError("Cancelled properties cannot be sold.")
+            if record.state == 'sold':
+                raise UserError("The property is already sold.")
+            if not record.offer_ids.filtered(lambda o: o.status == 'accepted'):
+                raise UserError("You cannot sell a property without an accepted offer.")
             record.state = 'sold'
 
     def action_cancel(self):

real_estate/models/estate_property_offer.py

@@ -61,17 +61,19 @@ def action_refuse(self):
 
     @api.model_create_multi
     def create(self, vals_list):
-        property_ids = list({vals['property_id'] for vals in vals_list if 'property_id' in vals})
-        property_records = self.env['estate.property'].browse(property_ids)
-        property_map = {prop.id: prop for prop in property_records}
         for vals in vals_list:
+            price = vals.get('price')
             property_id = vals.get('property_id')
-            property_rec = property_map.get(property_id)
-            if property_rec:
-                existing_offers = property_rec.offer_ids.filtered(
-                    lambda o: o.price >= vals.get('price', 0)
-                )
-                if existing_offers:
-                    raise ValidationError("You cannot create an offer lower than or equal to an existing one.")
-                property_rec.state = 'offer_received'
+            if not property_id:
+                raise ValidationError("Property ID must be provided.")
+            property_obj = self.env['estate.property'].browse(property_id)
+
+            if property_obj.state == 'sold':
+                raise UserError("Cannot create offer for a sold property.")
+            existing_offers = property_obj.offer_ids.filtered(
+                lambda o: o.price is not None and price is not None and o.price >= price
+            )
+            if existing_offers:
+                raise ValidationError("You cannot create an offer with a lower or equal price than existing offers.")
+            property_obj.state = 'offer_received'
         return super().create(vals_list)

real_estate/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_estate_offer

real_estate/tests/test_estate_offer.py

@@ -0,0 +1,63 @@
+from odoo.tests.common import TransactionCase
+from odoo.tests import Form
+from odoo.exceptions import UserError
+from odoo.tests import tagged
+
+
+@tagged('post_install', '-at_install')
+class TestEstatePropertyLogic(TransactionCase):
+
+    def setUp(self):
+        super().setUp()
+        Property = self.env['estate.property']
+        Offer = self.env['estate.property.offer']
+        self.partner = self.env['res.partner'].create({
+            'name': 'Test Buyer',
+            'email': '[email protected]'
+        })
+        self.property = Property.create({
+            'name': 'Test Property',
+            'state': 'new',
+            'expected_price': 150000,
+            'garden': True,
+            'garden_area': 100,
+            'garden_orientation': 'north',
+        })
+        self.offer = Offer.create({
+            'property_id': self.property.id,
+            'partner_id': self.partner.id,
+            'price': 160000,
+        })
+
+    def test_cannot_create_offer_on_sold_property(self):
+        self.property.state = 'sold'
+        with self.assertRaises(UserError):
+            self.env['estate.property.offer'].create({
+                'property_id': self.property.id,
+                'partner_id': self.partner.id,
+                'price': 170000
+            })
+
+    def test_cannot_sell_property_without_accepted_offer(self):
+        self.property.offer_ids.unlink()
+        with self.assertRaises(UserError):
+            self.property.action_sold()
+
+    def test_can_sell_property_with_accepted_offer(self):
+        self.offer.action_accept()
+        self.property.action_sold()
+        self.assertEqual(self.property.selling_price, self.offer.price)
+        self.assertEqual(self.property.buyer, self.partner)
+
+    def test_reset_garden_fields_when_unchecked(self):
+        form = Form(self.env['estate.property'])
+        form.name = 'Garden Test'
+        form.garden = True
+        form.expected_price = 15000
+        form.garden_area = 50
+        form.garden_orientation = 'east'
+        prop = form.save()
+        prop.garden = False
+        prop._onchange_garden()
+        self.assertEqual(prop.garden_area, 0)
+        self.assertFalse(prop.garden_orientation)