[IMP] estate: code style fixes

- Cleaned up code to meet linting and CI style standards.

Author: kums-odoo

estate/__init__.py

@@ -1,2 +1 @@
-
-from . import models
+from . import models

estate/__manifest__.py

@@ -1,16 +1,15 @@
 {
-    'name': 'Real Estate',
-    'category': 'Tutorials/RealEstate',
-    'application': True,
-    'installable': True,
-      'data': [
-        'views/estate_property_views.xml',
-        'views/estate_property_tag_views.xml',
-        'views/estate_property_offer_views.xml',
-        'views/estate_property_type_views.xml',
-        'views/estate_menus.xml',
-        'views/inherit_res_users_view.xml',
-        'security/ir.model.access.csv'
-        
-        ]
-}
+    "name": "Real Estate",
+    "category": "Tutorials/RealEstate",
+    "application": True,
+    "installable": True,
+    "data": [
+        "views/estate_property_views.xml",
+        "views/estate_property_tag_views.xml",
+        "views/estate_property_offer_views.xml",
+        "views/estate_property_type_views.xml",
+        "views/estate_menus.xml",
+        "views/inherit_res_users_view.xml",
+        "security/ir.model.access.csv",
+    ],
+}

estate/models/__init__.py

@@ -2,4 +2,4 @@
 from . import estate_property_type
 from . import estate_property_tag
 from . import estate_property_offer
-from . import inherited_res_users
+from . import inherited_res_users

estate/models/estate_property.py

@@ -1,4 +1,3 @@
-
 from odoo import fields, models, api
 from dateutil.relativedelta import relativedelta
 from datetime import date
@@ -8,76 +7,96 @@
 
 
 class EstateProperty(models.Model):
-    
     _name = "estate.property"
     _description = "Estate Model"
 
     name = fields.Char()
-    description= fields.Text()
+    description = fields.Text()
     postcode = fields.Text()
-    date_availability = fields.Date(copy=False, default= lambda self:date.today() + relativedelta(months=3))
+    date_availability = fields.Date(
+        copy=False, default=lambda self: date.today() + relativedelta(months=3)
+    )
     expected_price = fields.Float()
     selling_price = fields.Integer(readonly=True, copy=False)
     bedrooms = fields.Integer(default=2)
     living_area = fields.Integer()
     facades = fields.Integer()
     garage = fields.Boolean()
-    garden  = fields.Boolean()
-    garden_area = fields.Integer()  
+    garden = fields.Boolean()
+    garden_area = fields.Integer()
     garden_orientation = fields.Selection(
-            string='Type',
-            selection=[('north', 'North'), ('south', 'South'),('east', 'East'),('west', 'West')],
-        )   
+        string="Type",
+        selection=[
+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West"),
+        ],
+    )
 
     active = fields.Boolean(default=True)
 
     state = fields.Selection(
         selection=[
-            ('new', 'New'), ('offer_received', 'Offer Received '),
-            ('offer_accepted', 'Offer Accepted'), ('sold','Sold'),
-            ('cancelled' ,'Cancelled')],
-        string='Status',
-        default = 'new',
-        copy = False
+            ("new", "New"),
+            ("offer_received", "Offer Received "),
+            ("offer_accepted", "Offer Accepted"),
+            ("sold", "Sold"),
+            ("cancelled", "Cancelled"),
+        ],
+        string="Status",
+        default="new",
+        copy=False,
     )
 
     # property will have Many to one relation with property type since many properties can belong to one property type
 
-    property_type_id = fields.Many2one("estate.property.type", "Property Type") 
-
-    user_id = fields.Many2one('res.users', string='Salesperson',  copy=False, default=lambda self: self.env.user)
-
-    partner_id = fields.Many2one('res.partner', string='Buyer',  copy=False, )
-
-
-    tag_ids = fields.Many2many("estate.property.tag", string = "Tags")
+    property_type_id = fields.Many2one("estate.property.type", "Property Type")
 
+    user_id = fields.Many2one(
+        "res.users",
+        string="Salesperson",
+        copy=False,
+        default=lambda self: self.env.user,
+    )
 
-    offer_ids = fields.One2many('estate.property.offer', 'property_id', string="Offers")
+    partner_id = fields.Many2one(
+        "res.partner",
+        string="Buyer",
+        copy=False,
+    )
 
+    tag_ids = fields.Many2many("estate.property.tag", string="Tags")
 
-    total_area = fields.Integer(compute = "_compute_total_property_area")
+    offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
 
+    total_area = fields.Integer(compute="_compute_total_property_area")
 
-    best_price = fields.Integer(compute = "_best_property_offer")
+    best_price = fields.Integer(compute="_best_property_offer")
 
-    status = fields.Char(default='new')
+    status = fields.Char(default="new")
 
     _order = "id desc"
 
-
-    _sql_constraints = [('check_expected_price', 'CHECK(expected_price > 0)', 'Expected price must be strictly positive'),
-        ('check_selling_price', 'CHECK(selling_price >= 0)', 'Selling price should be positive')
+    _sql_constraints = [
+        (
+            "check_expected_price",
+            "CHECK(expected_price > 0)",
+            "Expected price must be strictly positive",
+        ),
+        (
+            "check_selling_price",
+            "CHECK(selling_price >= 0)",
+            "Selling price should be positive",
+        ),
     ]
-   
 
     @api.depends("garden_area", "living_area")
     def _compute_total_property_area(self):
         for area in self:
             self.total_area = self.garden_area + self.living_area
 
-
-    @api.depends('offer_ids.price')
+    @api.depends("offer_ids.price")
     def _best_property_offer(self):
         for record in self:
             offers_list = record.mapped("offer_ids.price")
@@ -86,88 +105,70 @@ def _best_property_offer(self):
                 return
             self.best_price = 0
 
-
-
-
     # on change of garden status , update gardern area and its orientation
 
-    @api.onchange('garden')
+    @api.onchange("garden")
     def _onchange_garden_status(self):
         if self.garden:
             self.garden_area = 10
-            self.garden_orientation = 'north'
+            self.garden_orientation = "north"
             return
         self.garden_area = 0
-        self.garden_orientation = ''
-      
+        self.garden_orientation = ""
 
-    # acts when property is sold 
+    # acts when property is sold
     # In case property is cancelled it cannot be sold
     def action_sell_property(self):
-       
-        # dictionary for the property status 
-        property_sell_status_dict = {
-            'new' : True,
-            'sold': True,
-            'cancelled': False
-        }
+        # dictionary for the property status
+        property_sell_status_dict = {"new": True, "sold": True, "cancelled": False}
 
         for record in self:
             print("the object on sell action", record.read())
             if property_sell_status_dict[record.status]:
-                record.status = 'sold'
-                record.state = 'sold'
+                record.status = "sold"
+                record.state = "sold"
                 return
-            raise UserError('Cancelled property cannot be sold.')
-
+            raise UserError("Cancelled property cannot be sold.")
 
     # action in case of cancel property button
-    #  If property is sold than Cannot be cancelled        
+    #  If property is sold than Cannot be cancelled
 
     def action_cancel_property_selling(self):
         property_cancel_status_dict = {
-            'new' : True,
-            'cancelled': True,
-            'sold': False,
+            "new": True,
+            "cancelled": True,
+            "sold": False,
         }
         for record in self:
             if property_cancel_status_dict[record.status]:
-                    record.status = 'cancelled'
-                    return
-            raise UserError('Sold  property cannot be cancelled.')
-        
-
-
-    # constrains for the selling price 
+                record.status = "cancelled"
+                return
+            raise UserError("Sold  property cannot be cancelled.")
 
-    @api.constrains('selling_price', 'expected_price')
+    # constrains for the selling price
 
+    @api.constrains("selling_price", "expected_price")
     def _check_selling_price(self):
-        
         for data in self:
             # if call will come after selling price change than it will allow updated price to work
-            if data.selling_price <= 0 :
+            if data.selling_price <= 0:
                 return
 
-            price_float_ratio = (data.selling_price/self.expected_price)
-            ratio_diffrence = float_compare(price_float_ratio,0.9, precision_digits=2)
-            if ratio_diffrence == -1 :
+            price_float_ratio = data.selling_price / self.expected_price
+            ratio_diffrence = float_compare(price_float_ratio, 0.9, precision_digits=2)
+            if ratio_diffrence == -1:
                 data.selling_price = 0
-                raise  ValidationError('The selling price cannot be lower than 90% of the expected price')
+                raise ValidationError(
+                    "The selling price cannot be lower than 90% of the expected price"
+                )
                 return
-            
-
 
     # delete opration for the process
 
-
     @api.ondelete(at_uninstall=False)
     def _unlink_if_state_new_or_cancelled(self):
         for data in self:
-            if not bool(self.state == 'new' or self.state == 'cancelled') : 
-                raise UserError("Can't delete property which is not in new or cancelled state!")
-                
-
-
-
-    
+            if not bool(self.state == "new" or self.state == "cancelled"):
+                raise UserError(
+                    "Can't delete property which is not in new or cancelled state!"
+                )