[ADD] estate,*: added real estate module #848

rvar-odoo · 2025-07-09T10:17:17Z

*=estate_account

-Added base estate and estate_account modules with models, security rules, and basic views.
-Implemented relational fields (many2one, one2many, many2many) and computed fields with dependencies.
-Added onchange methods for dynamic form behaviors.
-Created server actions, constraints, and automated workflows to enhance business logic.
-Developed PDF reports for property offers using QWeb and extended them in estate_account to include invoice details.
-Integrated mixins, HTTP controllers, and data loading mechanisms.
-Organized templates, report actions, and updated manifest files for proper module structure.
-Enabled data loading and module inheritance for extended functionality.

Created new 'estate' module. Added base model 'estate.property' with fields mentioned in exercise. Set up module structure. Set 'name' and 'expected_price' as required fields.

robodoo · 2025-07-09T10:17:19Z

maad-odoo

Quick first review.

Remove the unnecessary diff added in the code base.
Also the PR title is not correct, please adapt that as well

maad-odoo · 2025-07-10T17:58:24Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


Missing licensing

maad-odoo · 2025-07-10T17:58:49Z

estate/__manifest__.py

+    "installable": True,
+    "depends": ["base"],
+    "application": True,
+    "auto_install": False,


If the value is false, then no need to define it anyways

maad-odoo · 2025-07-10T17:59:10Z

estate/__manifest__.py

+    "summary": "Demo app for estate",
+    "description": "This is the demo app ",


Add a proper summary and description

maad-odoo · 2025-07-10T18:00:39Z

estate/models/estate_property.py

+class RecurringPlan(models.Model):
+    _name = "estate.property"
+    _description = "estate property revenue plans"


Mismatch class name and model name

maad-odoo · 2025-07-10T18:00:51Z

estate/models/estate_property.py

+class RecurringPlan(models.Model):
+    _name = "estate.property"
+    _description = "estate property revenue plans"
+    _order = "id desc"  # For ordering in ascending opr descending order   one more way to do so is from view like: <list default_order="date desc">


Comment is not required here

maad-odoo · 2025-07-10T18:05:35Z

estate/models/estate_property_offer.py

+            # Allow only if property has no accepted offer
+            if offer.property_id.buyer_id:
+                raise UserError(
+                    _("An offer has already been accepted for this property.")
+                )
+            # Set buyer and selling price
+            offer.property_id.buyer_id = offer.partner_id
+            offer.property_id.selling_price = offer.price
+            offer.status = "accepted"
+            offer.property_id.state = "offer_accepted"
+            # Setting remaining Offer as refused
+            other_offers = offer.property_id.offer_id - offer
+            # for other in other_offers:                  # -----> Normal for loop logic
+            #     other.status = 'refused'
+            other_offers.write({"status": "refused"})  # -----> Odoo ORM Method


Comment are unnecesary

maad-odoo · 2025-07-10T18:06:13Z

estate/models/estate_property_offer.py

+
+        return super().create(new_records)
+
+        # vals_list---------> [{'partner_id': 23, 'price': 100, 'validity': 7, 'date_deadline': '2025-07-16', 'property_id': 19}]


Unnecessary

maad-odoo · 2025-07-10T18:06:28Z

estate/security/ir.model.access.csv

+access_estate_model,estate.property,model_estate_property,base.group_user,1,1,1,1
+access_estate_model_property,estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_model_tag,estate.property.tag,model_estate_property_tag,base.group_user,1,1,1,1
+access_estate_model_offer,estate.property.offer,model_estate_property_offer,base.group_user,1,1,1,1


End of file line is missing

maad-odoo · 2025-07-10T18:06:53Z

estate/views/res_users_views.xml

+    </field>
+
+</record>
+</odoo>


End of file line is missing

maad-odoo · 2025-07-10T18:07:58Z

estate_account/models/estate_property.py

+            journal = self.env["account.journal"].search(
+                [("type", "=", "sale")], limit=1
+            )


Do you think searching inside for loop is efficient way to do it ?

-Defined access rights and security rules for proper user control. -Created simple form and tree views for the module UI. -Established foundational structure for further feature development. -Follows Odoo 18 developer tutorial to demonstrate ORM, security, and views.

[IMP] Estate : Module with security and basic views - Added relational fields (many2one, one2many, many2many) to link properties, users, and offers. - Introduced computed and stored fields with dependencies for automatic data updates (e.g., total area, best offer). - Implemented onchange methods for dynamic form updates and improved user experience. - Added server actions to extend business logic and automate workflows. - Improves data integrity, modularity, and aligns with Odoo’s reactive design principles.

[IMP] Estate : Module with security and basic views -Added relational fields (many2one, one2many, many2many) to link properties, users, and offers. -Introduced computed and stored fields with @api.depends for automatic updates (e.g., total area, best offer). -Implemented onchange methods for dynamic form updates and improved user experience. -Added server actions to support automated workflows and extended business logic. -Strengthens data integrity and aligns with Odoo’s modular, reactive design principles.

Added SQL constraints to ensure: Property expected price is strictly positive Property selling price is positive Offer price is strictly positive Property tag name and property type name are unique Added Python constraint to prevent selling price from being set below 90% of expected price Changes in UI: Added inline list view for properties on property type form Used statusbar widget for property state display Defined default ordering for models and enabled manual ordering for property types via sequence field Applied widget options to restrict creation/editing of property types from property form

- Added model and view inheritance for extending existing functionality. - Implemented interaction with external modules using dependencies. - Updated estate module to demonstrate cross-module field access and method calls.

- Implemented cross-module field access and method calls to demonstrate interaction with other modules. - Cleaned codebase to fix linter errors and improve readability.

- Added new module estate_account - Implemented cross-module field access and method calls to demonstrate interaction with other modules. - Cleaned codebase to fix linter errors and improve readability.

- Added demo data and security data to the estate module. - Implemented record rules and access rights to restrict data access based on user groups. - Updated __manifest__.py to load new data files. - Corrected linter issues and applied changes based on code review feedback.

-Created a PDF report for estate properties listing all property offers using QWeb templates and report actions. -Extended the report in estate_account to include invoice details for sold properties. -Organized templates and report actions within their respective modules. -Updated manifest files to register new reports. -Enhances reporting by allowing users to generate comprehensive property and financial documents from the UI.

maad-odoo

The previous comments are not applied.
The PR still contains a lot of unnecessary diffs and missing has a lot of linting issue.
Some file names are not following proper guidlines.
EOF line missing in a lot of files

Please Update the PR so that it can be further reviews

- Introduced new unit tests in the estate module covering key business processes: - Prevent offer creation on sold properties. - Disallow marking properties as sold without an accepted offer. - Ensure garden area and orientation fields reset appropriately when garden is unchecked. -Fix linter issues and apply code review suggestions. - These tests improve the reliability and maintainability of the estate workflow.

maad-odoo

The Previous changes are still not resolved.
Please adapt the PR accordingly...

maad-odoo · 2025-07-18T08:14:45Z

estate/models/estate_property_type.py

+    sequence = fields.Integer(
+        "Sequence", default=10, help="Used to order property types."
+    )


What's the use of this sequence ?

It was mentioned in the exercise to add it, so I assumed it might be useful in a later exercise.

maad-odoo · 2025-07-18T08:15:10Z

estate/models/inherited_res_users.py

+from odoo import models, fields
+
+
+class InheritedResUsers(models.Model):


Call name does not follow coding guildlines

maad-odoo · 2025-07-18T08:16:36Z

estate/report/estate_property_report_templates.xml

+                    <div class="page">
+                        <h1>
+                            <span t-field="property.name"/>
+                        </h1    >


Suggested change

</h1 >

</h1>

maad-odoo · 2025-07-18T08:19:50Z

estate/views/estate_property_views.xml

+        <field name="name">estate.property.form</field>
+        <field name="model">estate.property</field>
+        <field name="arch" type="xml">
+            <form string="Name">


Give a proper specific name

maad-odoo · 2025-07-18T08:20:23Z

estate/views/estate_property_views.xml

+                        </page>
+                        <page string="Offers">
+                            <field name="offer_id" readonly="state in ('offer_accepted', 'sold', 'cancelled')">
+                                <list editable="bottom" decoration-danger="status == 'refused'" decoration-success="status == 'accepted'">                                    <!-- editable="bottom" for edit without opening form-->


Remove the commented line if not needed

maad-odoo · 2025-07-18T08:25:51Z

estate/models/estate_property_offer.py

+            offer.property_id.selling_price = offer.price
+            offer.status = "accepted"
+            offer.property_id.state = "offer_accepted"
+            # Setting remaining Offer as refused


maad-odoo · 2025-07-18T08:26:01Z

estate/models/estate_property_offer.py

+            offer.property_id.selling_price = offer.price
+            offer.status = "accepted"
+            offer.property_id.state = "offer_accepted"
+            # Setting remaining Offer as refused


maad-odoo · 2025-07-18T08:28:52Z

estate_account/__manifest__.py

+    "name": "Estate Account",
+    "summary": "Integrate real estate operations with accounting",
+    "description": "Extends the Real Estate app to handle financial operations. Automates invoicing, tracks commissions, and links property sales with accounting workflows for seamless integration",
+    "depends": ["base", "estate", "account"],


One of the dependency estate have base already in its own dependency, so why do we need this explicitly here ?

Actually, I was aware that one of its dependencies includes base, but I didn’t realize we don’t need to declare it again in such cases. I’ll update it accordingly. Thanks for letting me know.

maad-odoo · 2025-07-18T08:30:11Z

estate/__manifest__.py

+    "installable": True,
+    "depends": ["base"],
+    "application": True,
+    "license": "AGPL-3",


why not LGPL-3 ?

I took reference from one of the existing modules and didn’t realize I should be using LGPL-3 here. I understand now that AGPL-3 requires sharing all changes, while LGPL-3 allows more flexibility for private use. I’ll update the license.

maad-odoo · 2025-07-18T08:30:29Z

estate_account/__manifest__.py

+    "depends": ["base", "estate", "account"],
+    "category": "Tutorials",
+    "installable": True,
+    "license": "AGPL-3",


Why not LGPL-3 ?

…utorial Introduce initial Owl components as part of the JavaScript framework learning exercise. Includes examples of reactive state, component composition, prop passing, template rendering, and event handling using Owl.

- Developed a custom dashboard module utilizing OWL and JavaScript to present important business metrics in a visually appealing and interactive interface. - The dashboard pulls real-time data from backend models, displaying it through summary cards and various charts. - This module serves as a practical example of constructing responsive dashboard in Odoo with client-side rendering and tailor-made components

[ADD] estate: initial module for real estate properties

1db8870

Created new 'estate' module. Added base model 'estate.property' with fields mentioned in exercise. Set up module structure. Set 'name' and 'expected_price' as required fields.

rvar-odoo force-pushed the 18.0-training-rvar branch 4 times, most recently from 93657db to b6e2c1e Compare July 10, 2025 06:55

maad-odoo reviewed Jul 10, 2025

View reviewed changes

rvar-odoo changed the title ~~18.0 training rvar~~ [ADD] estate,*: added real estate module Jul 14, 2025

rvar-odoo force-pushed the 18.0-training-rvar branch 3 times, most recently from 454d05d to 127ad83 Compare July 15, 2025 13:29

rvar-odoo force-pushed the 18.0-training-rvar branch from 127ad83 to f32463a Compare July 16, 2025 06:38

rvar-odoo added 8 commits July 16, 2025 12:17

[IMP] estate: add inheritance and module interaction features

2193137

- Added model and view inheritance for extending existing functionality. - Implemented interaction with external modules using dependencies. - Updated estate module to demonstrate cross-module field access and method calls.

[IMP] estate: interact with external modules and code cleanup

b5a40ba

- Implemented cross-module field access and method calls to demonstrate interaction with other modules. - Cleaned codebase to fix linter errors and improve readability.

[ADD] estate_account: interact with external modules and code cleanup

9524cb6

- Added new module estate_account - Implemented cross-module field access and method calls to demonstrate interaction with other modules. - Cleaned codebase to fix linter errors and improve readability.

rvar-odoo force-pushed the 18.0-training-rvar branch from f32463a to 5fb5928 Compare July 16, 2025 06:48

maad-odoo suggested changes Jul 16, 2025

View reviewed changes

rvar-odoo force-pushed the 18.0-training-rvar branch 3 times, most recently from 6054f0d to dc39666 Compare July 17, 2025 10:47

rvar-odoo force-pushed the 18.0-training-rvar branch from dc39666 to 6792087 Compare July 17, 2025 12:01

maad-odoo suggested changes Jul 18, 2025

View reviewed changes

rvar-odoo force-pushed the 18.0-training-rvar branch from 5af7436 to 7ffe14f Compare July 18, 2025 17:05

rvar-odoo force-pushed the 18.0-training-rvar branch from 7ffe14f to 75c8658 Compare July 18, 2025 17:11

rvar-odoo force-pushed the 18.0-training-rvar branch from 75c8658 to 5518b4e Compare July 18, 2025 17:17

		"summary": "Demo app for estate",
		"description": "This is the demo app ",


		return super().create(new_records)

		# vals_list---------> [{'partner_id': 23, 'price': 100, 'validity': 7, 'date_deadline': '2025-07-16', 'property_id': 19}]

		from odoo import models, fields


		class InheritedResUsers(models.Model):

[ADD] estate,*: added real estate module #848

Are you sure you want to change the base?

[ADD] estate,*: added real estate module #848

Uh oh!

Conversation

rvar-odoo commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Jul 9, 2025

Uh oh!

maad-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maad-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maad-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rvar-odoo commented Jul 9, 2025 •

edited

Loading

maad-odoo left a comment •

edited

Loading