Skip to content

Commit 3321a73

Browse files
committed
move debug away from with debug
1 parent 878bd5c commit 3321a73

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

config.go

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ package tablewriter
33

44
import (
55
"github.com/olekukonko/ll" // Logging library for debug output
6-
"github.com/olekukonko/ll/lx" // Logging level extensions
76
"github.com/olekukonko/tablewriter/tw" // Tablewriter core types and utilities
87
"io" // Input/output interfaces
98
"reflect" // Reflection for type handling
@@ -743,18 +742,6 @@ func WithConfig(cfg Config) Option {
743742
func WithDebug(debug bool) Option {
744743
return func(target *Table) {
745744
target.config.Debug = debug
746-
if target.logger != nil {
747-
if debug {
748-
target.logger.Enable()
749-
target.logger.Level(lx.LevelDebug)
750-
} else {
751-
target.logger.Level(lx.LevelInfo)
752-
}
753-
target.logger.Debug("Option: WithDebug applied to Table: %v", debug)
754-
if target.renderer != nil {
755-
target.renderer.Logger(target.logger)
756-
}
757-
}
758745
}
759746
}
760747

tablewriter.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,12 @@ func NewTable(w io.Writer, opts ...Option) *Table {
126126
opt(t)
127127
}
128128

129+
// force debugging mode if set
130+
// This should be move away form WithDebug
131+
if t.config.Debug == true {
132+
t.logger.Enable()
133+
}
134+
129135
// send logger to renderer
130136
// this will overwrite the default logger
131137
t.renderer.Logger(t.logger)

0 commit comments

Comments
 (0)