Skip to content

[CUDA][HIP][OpenCL][NATIVECPU] Fix multi-device compile #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Nov 21, 2023

Ensure that all adapters have the correct signatures for the multi-device compile experimental feature entry points and that they entry points exist even when returning UR_RESULT_ERROR_UNSUPPORTED_FEATURE.

Fixes the failing checks in intel/llvm#11464.

@kbenzie kbenzie requested review from a team as code owners November 21, 2023 13:43
Copy link
Contributor

@callumfare callumfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Ensure that all adapters have the correct signatures for the
multi-device compile experimental feature entry points and that they
entry points exist even when returning
`UR_RESULT_ERROR_UNSUPPORTED_FEATURE`.
@kbenzie kbenzie force-pushed the benie/fixup-multi-device-compile branch from cdababd to e001b98 Compare November 21, 2023 14:56
Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU LGTM, thank you

@kbenzie kbenzie merged commit 71957e8 into oneapi-src:adapters Nov 21, 2023
@kbenzie kbenzie deleted the benie/fixup-multi-device-compile branch June 11, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants