Skip to content

[UR] Refactor urDevicePartition to use desc struct #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

veselypeta
Copy link
Contributor

@veselypeta veselypeta commented May 23, 2023

Discussion on the approach can be seen in #401

@veselypeta veselypeta force-pushed the petr/device-partition-properties branch from f907ba0 to a6c08a3 Compare May 23, 2023 14:20
@veselypeta veselypeta force-pushed the petr/device-partition-properties branch from a6c08a3 to 5ebf643 Compare May 23, 2023 14:52
@fabiomestre
Copy link
Contributor

I agree with Bennie's suggestion. But looks good to me otherwise 👍

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one comment

@veselypeta veselypeta force-pushed the petr/device-partition-properties branch 2 times, most recently from 71c50a4 to 0ed16b1 Compare May 30, 2023 08:24
@veselypeta veselypeta force-pushed the petr/device-partition-properties branch from 0ed16b1 to cf739e0 Compare May 30, 2023 14:24
@veselypeta veselypeta merged commit 758c7e2 into oneapi-src:main May 31, 2023
@veselypeta veselypeta deleted the petr/device-partition-properties branch May 31, 2023 08:19
dm-vodopyanov added a commit to dm-vodopyanov/llvm that referenced this pull request Jun 14, 2023
…RSION

This should have been an obvious update of Unified Runtime sources to support
UR_DEVICE_INFO_IP_VERSION, required in
intel#9843, but this update brought
many API breaks mostly caused by this patch:
oneapi-src/unified-runtime#536
dm-vodopyanov added a commit to intel/llvm that referenced this pull request Jun 21, 2023
…RSION (#9873)

This should have been an obvious update of Unified Runtime tag to
support UR_DEVICE_INFO_IP_VERSION, required in
#9843 (just tag update, nothing else),
but it also brought many API breaks caused by this patch:
oneapi-src/unified-runtime#536. So the current
PR updates our codebase in accordance with changed UR API.

---------

Signed-off-by: Dmitry Vodopyanov <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: Jaime Arteaga <[email protected]>
veselypeta pushed a commit to veselypeta/llvm that referenced this pull request Sep 21, 2023
…RSION (intel#9873)

This should have been an obvious update of Unified Runtime tag to
support UR_DEVICE_INFO_IP_VERSION, required in
intel#9843 (just tag update, nothing else),
but it also brought many API breaks caused by this patch:
oneapi-src/unified-runtime#536. So the current
PR updates our codebase in accordance with changed UR API.

---------

Signed-off-by: Dmitry Vodopyanov <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: Jaime Arteaga <[email protected]>
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
…RSION (intel#9873)

This should have been an obvious update of Unified Runtime tag to
support UR_DEVICE_INFO_IP_VERSION, required in
intel#9843 (just tag update, nothing else),
but it also brought many API breaks caused by this patch:
oneapi-src/unified-runtime#536. So the current
PR updates our codebase in accordance with changed UR API.

---------

Signed-off-by: Dmitry Vodopyanov <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: Jaime Arteaga <[email protected]>
fabiomestre pushed a commit to fabiomestre/unified-runtime that referenced this pull request Sep 26, 2023
…RSION (#9873)

This should have been an obvious update of Unified Runtime tag to
support UR_DEVICE_INFO_IP_VERSION, required in
intel/llvm#9843 (just tag update, nothing else),
but it also brought many API breaks caused by this patch:
oneapi-src#536. So the current
PR updates our codebase in accordance with changed UR API.

---------

Signed-off-by: Dmitry Vodopyanov <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: Jaime Arteaga <[email protected]>
fabiomestre pushed a commit that referenced this pull request Sep 27, 2023
…RSION (#9873)

This should have been an obvious update of Unified Runtime tag to
support UR_DEVICE_INFO_IP_VERSION, required in
intel/llvm#9843 (just tag update, nothing else),
but it also brought many API breaks caused by this patch:
#536. So the current
PR updates our codebase in accordance with changed UR API.

---------

Signed-off-by: Dmitry Vodopyanov <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: Jaime Arteaga <[email protected]>
omarahmed1111 pushed a commit to omarahmed1111/unified-runtime that referenced this pull request Oct 23, 2023
…RSION (#9873)

This should have been an obvious update of Unified Runtime tag to
support UR_DEVICE_INFO_IP_VERSION, required in
intel/llvm#9843 (just tag update, nothing else),
but it also brought many API breaks caused by this patch:
oneapi-src#536. So the current
PR updates our codebase in accordance with changed UR API.

---------

Signed-off-by: Dmitry Vodopyanov <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: Jaime Arteaga <[email protected]>
omarahmed1111 pushed a commit to omarahmed1111/unified-runtime that referenced this pull request Oct 23, 2023
…RSION (#9873)

This should have been an obvious update of Unified Runtime tag to
support UR_DEVICE_INFO_IP_VERSION, required in
intel/llvm#9843 (just tag update, nothing else),
but it also brought many API breaks caused by this patch:
oneapi-src#536. So the current
PR updates our codebase in accordance with changed UR API.

---------

Signed-off-by: Dmitry Vodopyanov <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
Co-authored-by: Jaime Arteaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants