[UR][L0] Add the multi-device-compile experimental feature #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
changed the title
kbenzie
force-pushed
the
benie/multi-device-compile
branch
from
24b8d94 to
5d3c33c
Compare
kbenzie
force-pushed
the
benie/multi-device-compile
branch
from
5d3c33c to
73e9e32
Compare
|
All of them? They don't do the same things.
|
thanks @kbenzie for the clarification. |
jandres742
reviewed
Oct 10, 2023
| UR_APIEXPORT ur_result_t UR_APICALL | ||
| urProgramBuildExp( | ||
| ur_program_handle_t hProgram, ///< [in] Handle of the program to build. | ||
| uint32_t numDevices, ///< [in] number of devices |
There was a problem hiding this comment.
we could say here that if numDevices is 0, then urProgramBuildExp would be have the same as urProgramBuild, where the program is built for all the devices in the context.
piProgramBuild receives a list of devices, while urProgramBuild does not. This produces a series of issues when a UR program needs to be created for a specific device. So define a new API, called urProgramBuildExp to pass this list. Authored-by: [email protected]
veselypeta
approved these changes
Oct 26, 2023
callumfare
approved these changes
Oct 26, 2023
kbenzie
force-pushed
the
benie/multi-device-compile
branch
from
73e9e32 to
c16a5ce
Compare
Expand upon the introduction of `urProgramBuildExp` and include `urProgramCompileExp` and `urProgramLinkExp` which include a device-list in place of a context. These more closely align with the PI/OpenCL analogues but only to introduce device-lists, not all extant arguments from those entry-points. This patch also moves the `urProgramBuildExp` definition into an experimental feature file and introduces a brief document containing motivation.
kbenzie
force-pushed
the
benie/multi-device-compile
branch
from
c16a5ce to
c90b27b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the list of devices used to create a context, provide interfaces which instead take a list of devices. This more closely aligns with PI and OpenCL. Introduced to workaround a regression. May be superseded in future.
Pull's in the changes in #919 to the main branch.