Skip to content

[CI] Add support for OpenCL CI on CPU #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Oct 24, 2023

No description provided.

@fabiomestre fabiomestre force-pushed the fabio/opencl_ci branch 20 times, most recently from 6c6bf8d to 7963217 Compare October 27, 2023 14:58
@fabiomestre fabiomestre force-pushed the fabio/opencl_ci branch 5 times, most recently from 5427513 to 2d31de4 Compare November 16, 2023 14:58
@fabiomestre fabiomestre changed the title OpenCL CI trial and error [CI] Add support for OpenCL CI on CPU Nov 16, 2023
@fabiomestre fabiomestre marked this pull request as ready for review November 16, 2023 16:05
@fabiomestre fabiomestre requested review from a team as code owners November 16, 2023 16:05
@aarongreig
Copy link
Contributor

I'm surprised at how fast all the tests are running and at the mostly empty match files, are the tests definitely running and not getting skipped for some reason?

@fabiomestre
Copy link
Contributor Author

I'm surprised at how fast all the tests are running and at the mostly empty match files, are the tests definitely running and not getting skipped for some reason?

I'm surprised at how fast all the tests are running and at the mostly empty match files, are the tests definitely running and not getting skipped for some reason?

That's a good point. I will try to print the gtest output to see what is happening.

@fabiomestre fabiomestre force-pushed the fabio/opencl_ci branch 3 times, most recently from e95d653 to ebe929c Compare November 20, 2023 14:21
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kbenzie added a commit to kbenzie/intel-llvm that referenced this pull request Nov 24, 2023
In oneapi-src/unified-runtime#993 the type of
the `UR_OPENCL_ICD_LOADER_LIBRARY` CMake variable will change to a cache
variable, as such the usage of this variable also needs to up updated.
steffenlarsen pushed a commit to intel/llvm that referenced this pull request Nov 24, 2023
In oneapi-src/unified-runtime#993 the type of
the `UR_OPENCL_ICD_LOADER_LIBRARY` CMake variable will change to a cache
variable, as such the usage of this variable also needs to up updated.
kbenzie and others added 4 commits November 24, 2023 14:52
Introduces the follow CMake options:

* `UR_OPENCL_INCLUDE_DIR` - directory containing the OpenCL Headers
* `UR_OPENCL_ICD_LOADER_LIBRARY` - path of the OpenCL ICD Loader library

In the event that `UR_OPENCL_INCLUDE_DIR` is not specified, clone
[KhronosGroup/OpenCL-Headers](https://github.com/KhronosGroup/OpenCL-Headers.git).

In the event that `UR_OPENCL_ICD_LOADER_LIBRARY` is not specified, first
inspect the system with `find_package(OpenCL 3.0)` and use that if
found. Otherwise, clone
[KhronosGroup/OpenCL-ICD-Loader](https://github.com/KhronosGroup/OpenCL-ICD-Loader.git).
@kbenzie kbenzie merged commit 41228d3 into oneapi-src:adapters Nov 24, 2023
callumfare pushed a commit to kbenzie/intel-llvm that referenced this pull request Dec 18, 2023
In oneapi-src/unified-runtime#993 the type of
the `UR_OPENCL_ICD_LOADER_LIBRARY` CMake variable will change to a cache
variable, as such the usage of this variable also needs to up updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants