COMMON/UCX: suppressed coverity warnings #5934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- suppressed coverity warnings - added log messages on failed calls Signed-off-by: Sergey Oblomov <[email protected]>
|
@yosefe look please |
yosefe
reviewed
Oct 20, 2018
ompi/mca/osc/ucx/osc_ucx_component.c
Outdated
| @@ -825,7 +825,9 @@ int ompi_osc_ucx_free(struct ompi_win_t *win) { | |||
| ucp_worker_progress(mca_osc_ucx_component.ucp_worker); | |||
| } | |||
|
|
|||
| opal_common_ucx_worker_flush(mca_osc_ucx_component.ucp_worker); | |||
| if (OMPI_SUCCESS != opal_common_ucx_worker_flush(mca_osc_ucx_component.ucp_worker)) { | |||
| OSC_UCX_VERBOSE(1, "opal_common_ucx_worker_flush failed"); | |||
There was a problem hiding this comment.
pls print return code in all 3 error messages
Signed-off-by: Sergey Oblomov <[email protected]>
yosefe
approved these changes
Oct 22, 2018
|
👍 |
yosefe
approved these changes
Oct 22, 2018
yosefe
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sergey Oblomov [email protected]