PML OB1: Fix potential overcounting of SPC sent/received message sizes and account for fin messages #8067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joseph Schuchart <[email protected]>
…ing put mca_pml_ob1_recv_request_put_frag is used to request a put from the peer if get fails mca_pml_ob1_recv_request_ack_send_btl is used to send an acknowledgement, not data Signed-off-by: Joseph Schuchart <[email protected]>
|
@devreal I have nothing to do with the PML and cannot review that code |
|
@rhc54 Darn, I guess |
bosilca
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential over-counting of sent/received messages sizes in
pml/ob1: the two functionsmca_pml_ob1_recv_request_ack_send_btlandmca_pml_ob1_recv_request_put_fragdo not transfer payload but manage the underlying protocol, so count the transferred data accordingly. Also add instrumentation for sendingfinmessages inmca_pml_ob1_send_fin.