-
Notifications
You must be signed in to change notification settings - Fork 908
MAN: updated man-pages for lots of RMA window functions #8744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can one of the admins verify this patch? |
I would be happy to repeat this for v4. branches, let me know when you think this will be appropriate. :) |
The updates adds explanations of different MODES for the window synchronization routines as well as providing a bit more context for the baseptr (void *) data-types which are actually void ** types. Also added more cross-links. Finally added explanations of the Win_create_dynamic usage that explicitly requires attention about address spaces. I.e. the actual address at the target is necessary for succesfull operation. Signed-off-by: Nick Papior <[email protected]>
b808427
to
962608d
Compare
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zerothi Thanks for taking on this task. The changes are definitely helpful. I have made some suggestions for word-smithing the language (and just realized that I didn't batch them, sorry for the noise...)
@zerothi The sooner we can get this merged to master, the better, because we're actively working on converting the man pages to ReStructured text / Sphinx. Thanks! |
I haven't been able to do anything due to Easter, but feel free to amend however you wish, I can work on this tomorrow evening or 2 days from now. I am all busy tomorrow... |
ok, I found 5 minutes, I amended nearly everything @devreal suggested. Thanks. |
Signed-off-by: Nick Papior <[email protected]>
3ade0a7
to
377387b
Compare
Signed-off-by: Nick Papior <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zerothi, looks good now :)
@zerothi CI found an error -- can you update the .mailmap file?
|
It seems the same error occurs... I have no idea how to fix it. Please feel free to amend anything that fixes this, squash, merge and commit and lets get this in... :) |
Signed-off-by: Nick Papior <[email protected]>
f4bd43d
to
059b601
Compare
I don't know if the test should just restart? I can't see any clue in the console output? Seems like it just fails due to time? |
Sometimes we see Jenkins try to git clone from github and it fails with that git error (reference is not a tree). 🤷♂️ |
bot:ompi:retest |
Ok great, hope it is ready to get merged! |
@zerothi I just kicked it to run the CI test again. It'll almost certainly pass this time (we think the Jenkins issue is a race condition of some flavor -- e.g., possibly trying to check out the merge hash before it's actually available on github's CDNs). |
Perhaps a sleep could relieve the problem? Great it's merged! |
The updates adds explanations of different MODES for the
window synchronization routines as well as providing a bit
more context for the baseptr (void *) data-types which are actually
void ** types.
Also added more cross-links.
Finally added explanations of the Win_create_dynamic usage that explicitly
requires attention about address spaces. I.e. the actual address at the target
is necessary for succesfull operation.
This fixes #8680.