Skip to content

MAN: updated man-pages for lots of RMA window functions #8744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

zerothi
Copy link
Contributor

@zerothi zerothi commented Mar 31, 2021

The updates adds explanations of different MODES for the
window synchronization routines as well as providing a bit
more context for the baseptr (void *) data-types which are actually
void ** types.

Also added more cross-links.

Finally added explanations of the Win_create_dynamic usage that explicitly
requires attention about address spaces. I.e. the actual address at the target
is necessary for succesfull operation.

This fixes #8680.

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

@zerothi
Copy link
Contributor Author

zerothi commented Mar 31, 2021

I would be happy to repeat this for v4. branches, let me know when you think this will be appropriate. :)

The updates adds explanations of different MODES for the
window synchronization routines as well as providing a bit
more context for the baseptr (void *) data-types which are actually
void ** types.

Also added more cross-links.

Finally added explanations of the Win_create_dynamic usage that explicitly
requires attention about address spaces. I.e. the actual address at the target
is necessary for succesfull operation.

Signed-off-by: Nick Papior <[email protected]>
@awlauria
Copy link
Contributor

ok to test

Copy link
Contributor

@devreal devreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerothi Thanks for taking on this task. The changes are definitely helpful. I have made some suggestions for word-smithing the language (and just realized that I didn't batch them, sorry for the noise...)

@jsquyres
Copy link
Member

jsquyres commented Apr 5, 2021

@zerothi The sooner we can get this merged to master, the better, because we're actively working on converting the man pages to ReStructured text / Sphinx.

Thanks!

@zerothi
Copy link
Contributor Author

zerothi commented Apr 5, 2021

I haven't been able to do anything due to Easter, but feel free to amend however you wish, I can work on this tomorrow evening or 2 days from now. I am all busy tomorrow...

@zerothi
Copy link
Contributor Author

zerothi commented Apr 6, 2021

ok, I found 5 minutes, I amended nearly everything @devreal suggested. Thanks.
I did not mention C explicitly in the parts that are already in C notes sections. It seemed redundant to me :)

@zerothi zerothi force-pushed the 8680-manpage-win branch from 3ade0a7 to 377387b Compare April 6, 2021 09:18
Copy link
Contributor

@devreal devreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zerothi, looks good now :)

@jsquyres
Copy link
Member

jsquyres commented Apr 6, 2021

@zerothi CI found an error -- can you update the .mailmap file?

/usr/bin/perl "./contrib/dist/make-authors.pl" --skip-ok --quiet --srcdir="."

*** WARNING: The following people had the same email address:
***   Nick Papior, Nick Papior Andersen

*******************************************************************************
*** YOU SHOULD EDIT THE .mailmap FILE TO RESOLVE THESE WARNINGS!
*******************************************************************************

@zerothi
Copy link
Contributor Author

zerothi commented Apr 6, 2021

It seems the same error occurs... I have no idea how to fix it.
Nick Papior and Nick Papior Andersen are both me. Hence two emails for different names.

Please feel free to amend anything that fixes this, squash, merge and commit and lets get this in... :)

@zerothi
Copy link
Contributor Author

zerothi commented Apr 7, 2021

I don't know if the test should just restart? I can't see any clue in the console output? Seems like it just fails due to time?

@jsquyres
Copy link
Member

jsquyres commented Apr 7, 2021

I don't know if the test should just restart? I can't see any clue in the console output? Seems like it just fails due to time?

Sometimes we see Jenkins try to git clone from github and it fails with that git error (reference is not a tree). 🤷‍♂️

@jsquyres
Copy link
Member

jsquyres commented Apr 7, 2021

bot:ompi:retest

@zerothi
Copy link
Contributor Author

zerothi commented Apr 7, 2021

Sometimes we see Jenkins try to git clone from github and it fails with that git error (reference is not a tree).

Ok great, hope it is ready to get merged!

@jsquyres
Copy link
Member

jsquyres commented Apr 7, 2021

@zerothi I just kicked it to run the CI test again. It'll almost certainly pass this time (we think the Jenkins issue is a race condition of some flavor -- e.g., possibly trying to check out the merge hash before it's actually available on github's CDNs).

@jsquyres jsquyres merged commit bc321de into open-mpi:master Apr 7, 2021
@zerothi zerothi deleted the 8680-manpage-win branch April 7, 2021 15:01
@zerothi
Copy link
Contributor Author

zerothi commented Apr 7, 2021

@zerothi I just kicked it to run the CI test again. It'll almost certainly pass this time (we think the Jenkins issue is a race condition of some flavor -- e.g., possibly trying to check out the merge hash before it's actually available on github's CDNs).

Perhaps a sleep could relieve the problem?

Great it's merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context usage of MPI_Win_allocate for using MPI_Win_free and not MPI_Free_mem
5 participants