Skip to content

Commit 2dcfecd

Browse files
committed
Deprecate extensiontest.NewNopSettings
1 parent 398ceed commit 2dcfecd

File tree

40 files changed

+77
-77
lines changed

40 files changed

+77
-77
lines changed

exporter/fileexporter/encoding_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func TestEncoding(t *testing.T) {
4343
ef := otlpencodingextension.NewFactory()
4444
efCfg := ef.CreateDefaultConfig().(*otlpencodingextension.Config)
4545
efCfg.Protocol = "otlp_json"
46-
ext, err := ef.Create(context.Background(), extensiontest.NewNopSettings(), efCfg)
46+
ext, err := ef.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), efCfg)
4747
require.NoError(t, err)
4848
require.NoError(t, ext.Start(context.Background(), componenttest.NewNopHost()))
4949

extension/asapauthextension/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func TestCreate(t *testing.T) {
7272
cfg.PrivateKey = testcase.settings.PrivateKey
7373

7474
// validate extension creation
75-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
75+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
7676
if testcase.shouldError {
7777
assert.Error(t, err)
7878
} else {

extension/awsproxy/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func TestFactory_Create(t *testing.T) {
6262
t.Setenv("AWS_SECRET_ACCESS_KEY", "fakeSecretAccessKey")
6363

6464
ctx := context.Background()
65-
cs := extensiontest.NewNopSettings()
65+
cs := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
6666
ext, err := createExtension(ctx, cs, cfg)
6767
assert.NoError(t, err)
6868
assert.NotNil(t, ext)

extension/basicauthextension/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ func TestCreateExtension_ValidConfig(t *testing.T) {
2828
},
2929
}
3030

31-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
31+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3232
assert.NoError(t, err)
3333
assert.NotNil(t, ext)
3434
}

extension/bearertokenauthextension/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func TestFactory_CreateDefaultConfig(t *testing.T) {
2222
func TestFactory_Create(t *testing.T) {
2323
cfg := createDefaultConfig().(*Config)
2424
cfg.BearerToken = "somerandometoken"
25-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
25+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
2626
require.NoError(t, err)
2727
require.NotNil(t, ext)
2828
}

extension/cgroupruntimeextension/extension_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func TestExtension(t *testing.T) {
5353
allCalls++
5454
return func() { allCalls++ }, _err
5555
}
56-
settings := extensiontest.NewNopSettings()
56+
settings := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
5757
cg := newCgroupRuntime(test.config, settings.Logger, setterMock, func(_ float64) (undoFunc, error) { return setterMock() })
5858
ctx := context.Background()
5959

extension/encoding/jaegerencodingextension/extension_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestExtension_Start(t *testing.T) {
2323
name: "jaegerProtobuf",
2424
getExtension: func() (extension.Extension, error) {
2525
factory := NewFactory()
26-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), factory.CreateDefaultConfig())
26+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), factory.CreateDefaultConfig())
2727
},
2828
},
2929
{
@@ -32,7 +32,7 @@ func TestExtension_Start(t *testing.T) {
3232
factory := NewFactory()
3333
cfg := factory.CreateDefaultConfig()
3434
cfg.(*Config).Protocol = "xyz"
35-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
35+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3636
},
3737
expectedErr: "unsupported protocol: \"xyz\"",
3838
},

extension/encoding/otlpencodingextension/extension_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func TestExtension_Start(t *testing.T) {
3030
factory := NewFactory()
3131
cfg := factory.CreateDefaultConfig()
3232
cfg.(*Config).Protocol = "otlp_json"
33-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
33+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3434
},
3535
},
3636

@@ -40,7 +40,7 @@ func TestExtension_Start(t *testing.T) {
4040
factory := NewFactory()
4141
cfg := factory.CreateDefaultConfig()
4242
cfg.(*Config).Protocol = "otlp_proto"
43-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
43+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
4444
},
4545
},
4646
}

extension/encoding/skywalkingencodingextension/extension_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func TestExtension_Start(t *testing.T) {
2424
getExtension: func() (extension.Extension, error) {
2525
factory := NewFactory()
2626
cfg := factory.CreateDefaultConfig()
27-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
27+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
2828
},
2929
},
3030
}

extension/encoding/textencodingextension/extension_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestExtension_Start(t *testing.T) {
2323
name: "text",
2424
getExtension: func() (extension.Extension, error) {
2525
factory := NewFactory()
26-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), factory.CreateDefaultConfig())
26+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), factory.CreateDefaultConfig())
2727
},
2828
},
2929
{
@@ -32,7 +32,7 @@ func TestExtension_Start(t *testing.T) {
3232
factory := NewFactory()
3333
cfg := factory.CreateDefaultConfig()
3434
cfg.(*Config).Encoding = "gbk"
35-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
35+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3636
},
3737
},
3838
{
@@ -41,7 +41,7 @@ func TestExtension_Start(t *testing.T) {
4141
factory := NewFactory()
4242
cfg := factory.CreateDefaultConfig()
4343
cfg.(*Config).Encoding = "blabla"
44-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
44+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
4545
},
4646
expectedErr: "unsupported encoding 'blabla'",
4747
},

extension/encoding/zipkinencodingextension/extension_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ func TestExtension_Start(t *testing.T) {
2525
factory := NewFactory()
2626
cfg := factory.CreateDefaultConfig()
2727
cfg.(*Config).Protocol = "zipkin_json"
28-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
28+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
2929
},
3030
},
3131
{
@@ -34,7 +34,7 @@ func TestExtension_Start(t *testing.T) {
3434
factory := NewFactory()
3535
cfg := factory.CreateDefaultConfig()
3636
cfg.(*Config).Protocol = "zipkin_proto"
37-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
37+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3838
},
3939
},
4040
{
@@ -44,7 +44,7 @@ func TestExtension_Start(t *testing.T) {
4444
cfg := factory.CreateDefaultConfig()
4545
cfg.(*Config).Protocol = "zipkin_thrift"
4646
cfg.(*Config).Version = "v1"
47-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
47+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
4848
},
4949
},
5050
{
@@ -54,7 +54,7 @@ func TestExtension_Start(t *testing.T) {
5454
cfg := factory.CreateDefaultConfig()
5555
cfg.(*Config).Protocol = "zipkin_thrift"
5656
cfg.(*Config).Version = "v2"
57-
return factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
57+
return factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
5858
},
5959
expectedErr: "unsupported version: \"v2\"",
6060
},

extension/headerssetterextension/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func TestCreateDefaultConfig(t *testing.T) {
2424
func TestCreate(t *testing.T) {
2525
cfg := createDefaultConfig().(*Config)
2626

27-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
27+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
2828
assert.NoError(t, err)
2929
assert.NotNil(t, ext)
3030
}

extension/healthcheckextension/factory_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func TestFactory_CreateDefaultConfig(t *testing.T) {
2727
}, cfg)
2828

2929
assert.NoError(t, componenttest.CheckConfigStruct(cfg))
30-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
30+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3131
require.NoError(t, err)
3232
require.NotNil(t, ext)
3333
}
@@ -36,7 +36,7 @@ func TestFactory_Create(t *testing.T) {
3636
cfg := createDefaultConfig().(*Config)
3737
cfg.Endpoint = testutil.GetAvailableLocalAddress(t)
3838

39-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
39+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
4040
require.NoError(t, err)
4141
require.NotNil(t, ext)
4242
}

extension/healthcheckextension/integration_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ func Test_SimpleHealthCheck(t *testing.T) {
2424
port := testutil.GetAvailablePort(t)
2525
cfg := f.CreateDefaultConfig().(*Config)
2626
cfg.Endpoint = fmt.Sprintf("localhost:%d", port)
27-
e, err := f.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
27+
e, err := f.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
2828
require.NoError(t, err)
2929
err = e.Start(context.Background(), componenttest.NewNopHost())
3030
require.NoError(t, err)

extension/healthcheckv2extension/extension_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ func TestComponentStatus(t *testing.T) {
3030
cfg.HTTPConfig.Endpoint = testutil.GetAvailableLocalAddress(t)
3131
cfg.GRPCConfig.NetAddr.Endpoint = testutil.GetAvailableLocalAddress(t)
3232
cfg.UseV2 = true
33-
ext := newExtension(context.Background(), *cfg, extensiontest.NewNopSettings())
33+
ext := newExtension(context.Background(), *cfg, extensiontest.NewNopSettingsWithType(extensiontest.NopType))
3434

3535
// Status before Start will be StatusNone
3636
st, ok := ext.aggregator.AggregateStatus(status.ScopeAll, status.Concise)
@@ -109,7 +109,7 @@ func TestNotifyConfig(t *testing.T) {
109109
cfg.HTTPConfig.Config.Enabled = true
110110
cfg.HTTPConfig.Config.Path = "/config"
111111

112-
ext := newExtension(context.Background(), *cfg, extensiontest.NewNopSettings())
112+
ext := newExtension(context.Background(), *cfg, extensiontest.NewNopSettingsWithType(extensiontest.NopType))
113113

114114
require.NoError(t, ext.Start(context.Background(), componenttest.NewNopHost()))
115115
t.Cleanup(func() { require.NoError(t, ext.Shutdown(context.Background())) })

extension/healthcheckv2extension/factory_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func TestCreateDefaultConfig(t *testing.T) {
5555
assert.NoError(t, componenttest.CheckConfigStruct(cfg))
5656
ctx, cancel := context.WithCancel(context.Background())
5757
defer cancel()
58-
ext, err := createExtension(ctx, extensiontest.NewNopSettings(), cfg)
58+
ext, err := createExtension(ctx, extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
5959
require.NoError(t, err)
6060
require.NotNil(t, ext)
6161
}
@@ -65,7 +65,7 @@ func TestCreate(t *testing.T) {
6565
cfg.Endpoint = testutil.GetAvailableLocalAddress(t)
6666
ctx, cancel := context.WithCancel(context.Background())
6767
defer cancel()
68-
ext, err := createExtension(ctx, extensiontest.NewNopSettings(), cfg)
68+
ext, err := createExtension(ctx, extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
6969
require.NoError(t, err)
7070
require.NotNil(t, ext)
7171
}

extension/httpforwarderextension/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ func TestFactory(t *testing.T) {
5151
t.Run(test.name, func(t *testing.T) {
5252
e, err := f.Create(
5353
context.Background(),
54-
extensiontest.NewNopSettings(),
54+
extensiontest.NewNopSettingsWithType(extensiontest.NopType),
5555
test.config,
5656
)
5757
if test.wantErr {

extension/jaegerremotesampling/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func TestCreateDefaultConfig(t *testing.T) {
3636
func TestCreate(t *testing.T) {
3737
cfg := createDefaultConfig().(*Config)
3838

39-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
39+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
4040
assert.NoError(t, err)
4141
assert.NotNil(t, ext)
4242
}

extension/oauth2clientauthextension/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func TestCreate(t *testing.T) {
5454
cfg.ClientSecret = testcase.settings.ClientSecret
5555
cfg.TokenURL = testcase.settings.TokenURL
5656
cfg.Scopes = testcase.settings.Scopes
57-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
57+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
5858
if testcase.shouldError {
5959
assert.Error(t, err)
6060
assert.Nil(t, ext)

extension/observer/cfgardenobserver/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ func TestValidConfig(t *testing.T) {
2020
func TestCreateCFGardenObserver(t *testing.T) {
2121
cfGardenObserver, err := createExtension(
2222
context.Background(),
23-
extensiontest.NewNopSettings(),
23+
extensiontest.NewNopSettingsWithType(extensiontest.NopType),
2424
&Config{},
2525
)
2626
require.NoError(t, err)

extension/observer/dockerobserver/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ func TestValidConfig(t *testing.T) {
2020
func TestCreate(t *testing.T) {
2121
dockerObserver, err := createExtension(
2222
context.Background(),
23-
extensiontest.NewNopSettings(),
23+
extensiontest.NewNopSettingsWithType(extensiontest.NopType),
2424
&Config{},
2525
)
2626
require.NoError(t, err)

extension/observer/ecsobserver/extension_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ func TestExtensionStartStop(t *testing.T) {
3434
sdCfg := cfg.(*Config)
3535
sdCfg.RefreshInterval = refreshInterval
3636
sdCfg.ResultFile = output
37-
cs := extensiontest.NewNopSettings()
37+
cs := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
3838
ext, err := createExtensionWithFetcher(cs, sdCfg, f)
3939
require.NoError(t, err)
4040
return ext
@@ -59,7 +59,7 @@ func TestExtensionStartStop(t *testing.T) {
5959
sdCfg := cfg.(*Config)
6060
sdCfg.RefreshInterval = 100 * time.Millisecond
6161
sdCfg.ResultFile = "testdata/ut_ext_critical_error.actual.yaml"
62-
cs := extensiontest.NewNopSettings()
62+
cs := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
6363
statusEventChan := make(chan *componentstatus.Event)
6464
ext, err := createExtensionWithFetcher(cs, sdCfg, f)
6565
require.NoError(t, err)

extension/observer/ecstaskobserver/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ func TestFactoryCreatedExtensionIsEndpointsLister(t *testing.T) {
1818
cfg := etoFactory.CreateDefaultConfig()
1919
cfg.(*Config).Endpoint = "http://localhost:1234/mock/endpoint"
2020

21-
eto, err := etoFactory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
21+
eto, err := etoFactory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
2222
require.NoError(t, err)
2323
require.NotNil(t, eto)
2424
require.Implements(t, (*observer.EndpointsLister)(nil), eto)

extension/observer/hostobserver/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ func TestValidConfig(t *testing.T) {
2020
func TestCreateMetrics(t *testing.T) {
2121
hostObserver, err := createExtension(
2222
context.Background(),
23-
extensiontest.NewNopSettings(),
23+
extensiontest.NewNopSettingsWithType(extensiontest.NopType),
2424
&Config{},
2525
)
2626
require.NoError(t, err)

extension/observer/k8sobserver/extension_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func TestNewExtension(t *testing.T) {
3535
config := factory.CreateDefaultConfig().(*Config)
3636
mockServiceHost(t, config)
3737

38-
ext, err := newObserver(config, extensiontest.NewNopSettings())
38+
ext, err := newObserver(config, extensiontest.NewNopSettingsWithType(extensiontest.NopType))
3939
require.NoError(t, err)
4040
require.NotNil(t, ext)
4141
}
@@ -46,7 +46,7 @@ func TestExtensionObserveServices(t *testing.T) {
4646
config.ObservePods = false // avoid causing data race when multiple test cases running in the same process using podListerWatcher
4747
mockServiceHost(t, config)
4848

49-
set := extensiontest.NewNopSettings()
49+
set := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
5050
set.ID = component.NewID(metadata.Type)
5151
ext, err := newObserver(config, set)
5252
require.NoError(t, err)
@@ -135,7 +135,7 @@ func TestExtensionObservePods(t *testing.T) {
135135
config := factory.CreateDefaultConfig().(*Config)
136136
mockServiceHost(t, config)
137137

138-
set := extensiontest.NewNopSettings()
138+
set := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
139139
set.ID = component.NewID(metadata.Type)
140140
ext, err := newObserver(config, set)
141141
require.NoError(t, err)
@@ -219,7 +219,7 @@ func TestExtensionObserveNodes(t *testing.T) {
219219
config.ObservePods = false // avoid causing data race when multiple test cases running in the same process using podListerWatcher
220220
mockServiceHost(t, config)
221221

222-
set := extensiontest.NewNopSettings()
222+
set := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
223223
set.ID = component.NewID(metadata.Type)
224224
ext, err := newObserver(config, set)
225225
require.NoError(t, err)
@@ -320,7 +320,7 @@ func TestExtensionObserveIngresses(t *testing.T) {
320320
config.ObserveIngresses = true
321321
mockServiceHost(t, config)
322322

323-
set := extensiontest.NewNopSettings()
323+
set := extensiontest.NewNopSettingsWithType(extensiontest.NopType)
324324
set.ID = component.NewID(metadata.Type)
325325
ext, err := newObserver(config, set)
326326
require.NoError(t, err)

extension/observer/k8sobserver/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func TestFactory_Create(t *testing.T) {
2626
factory := NewFactory()
2727
cfg := factory.CreateDefaultConfig().(*Config)
2828

29-
ext, err := factory.Create(context.Background(), extensiontest.NewNopSettings(), cfg)
29+
ext, err := factory.Create(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3030
require.Error(t, err)
3131
require.Nil(t, ext)
3232
}

extension/oidcauthextension/factory_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func TestCreate(t *testing.T) {
3131
cfg.Audience = "collector"
3232
cfg.IssuerURL = "https://auth.example.com"
3333

34-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
34+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3535
assert.NoError(t, err)
3636
assert.NotNil(t, ext)
3737
}

extension/opampextension/factory_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ func TestFactory_CreateDefaultConfig(t *testing.T) {
1818
assert.Equal(t, createDefaultConfig().(*Config), cfg)
1919

2020
assert.NoError(t, componenttest.CheckConfigStruct(cfg))
21-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
21+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
2222
require.NoError(t, err)
2323
require.NotNil(t, ext)
2424
require.NoError(t, ext.Shutdown(context.Background()))
2525
}
2626

2727
func TestFactory_Create(t *testing.T) {
2828
cfg := NewFactory().CreateDefaultConfig()
29-
ext, err := createExtension(context.Background(), extensiontest.NewNopSettings(), cfg)
29+
ext, err := createExtension(context.Background(), extensiontest.NewNopSettingsWithType(extensiontest.NopType), cfg)
3030
require.NoError(t, err)
3131
require.NotNil(t, ext)
3232
require.NoError(t, ext.Shutdown(context.Background()))

0 commit comments

Comments
 (0)