SignalFx exporter: Fix producing cloud unique ID dimension (#966)

This change fixes creation of cloud unique ID based on attributes from resource detection processor

Author: dmitryax

exporter/signalfxexporter/translation/converter.go

@@ -75,6 +75,10 @@ var (
 
 	// infinity bound dimension value is used on all histograms.
 	infinityBoundSFxDimValue = float64ToDimValue(math.Inf(1))
+
+	// TODO: expose the constants somewhere in the project and share with resource detector processor
+	cloudProviderAWS = "aws"
+	cloudProviderGCP = "gcp"
 )
 
 // MetricsConverter converts MetricsData to sfxpb DataPoints. It holds an optional
@@ -420,8 +424,7 @@ func appendResourceAttributesToDimensions(dims []*sfxpb.Dimension, resourceAttr
 	filter := func(k string) bool { return true }
 
 	switch provider {
-	// TODO: Should these be defined as constants in resourcedetector module that we import or somewhere else?
-	case "ec2":
+	case cloudProviderAWS:
 		if instanceID == "" || region == "" || accountID == "" {
 			break
 		}
@@ -435,7 +438,7 @@ func appendResourceAttributesToDimensions(dims []*sfxpb.Dimension, resourceAttr
 			Key:   "AWSUniqueId",
 			Value: fmt.Sprintf("%s_%s_%s", instanceID, region, accountID),
 		})
-	case "gce":
+	case cloudProviderGCP:
 		if accountID == "" || instanceID == "" {
 			break
 		}

exporter/signalfxexporter/translation/converter_test.go

@@ -192,7 +192,7 @@ func Test_MetricDataToSignalFxV2(t *testing.T) {
 							Labels: map[string]string{
 								"k/r0":             "vr0",
 								"k/r1":             "vr1",
-								"cloud.provider":   "ec2",
+								"cloud.provider":   cloudProviderAWS,
 								"cloud.account.id": "efgh",
 								"cloud.region":     "us-east",
 							},
@@ -209,7 +209,7 @@ func Test_MetricDataToSignalFxV2(t *testing.T) {
 					tsMSecs,
 					&sfxMetricTypeGauge,
 					append([]string{"cloud_account_id", "cloud_provider", "cloud_region", "k_r0", "k_r1"}, keys...),
-					append([]string{"efgh", "ec2", "us-east", "vr0", "vr1"}, values...),
+					append([]string{"efgh", cloudProviderAWS, "us-east", "vr0", "vr1"}, values...),
 					doubleVal),
 			},
 		},
@@ -222,7 +222,7 @@ func Test_MetricDataToSignalFxV2(t *testing.T) {
 							Labels: map[string]string{
 								"k/r0":             "vr0",
 								"k/r1":             "vr1",
-								"cloud.provider":   "ec2",
+								"cloud.provider":   cloudProviderAWS,
 								"cloud.account.id": "efgh",
 								"cloud.region":     "us-east",
 								"host.id":          "abcd",
@@ -245,15 +245,15 @@ func Test_MetricDataToSignalFxV2(t *testing.T) {
 			},
 		},
 		{
-			name: "with_resources_cloud_gce_dim_partial",
+			name: "with_resources_cloud_gcp_dim_partial",
 			metricsDataFn: func() []consumerdata.MetricsData {
 				return []consumerdata.MetricsData{
 					{
 						Resource: &resourcepb.Resource{
 							Labels: map[string]string{
 								"k/r0":           "vr0",
 								"k/r1":           "vr1",
-								"cloud.provider": "gce",
+								"cloud.provider": cloudProviderGCP,
 								"host.id":        "abcd",
 							},
 						},
@@ -269,7 +269,7 @@ func Test_MetricDataToSignalFxV2(t *testing.T) {
 					tsMSecs,
 					&sfxMetricTypeGauge,
 					append([]string{"cloud_provider", "host_id", "k_r0", "k_r1"}, keys...),
-					append([]string{"gce", "abcd", "vr0", "vr1"}, values...),
+					append([]string{cloudProviderGCP, "abcd", "vr0", "vr1"}, values...),
 					doubleVal),
 			},
 		},
@@ -282,7 +282,7 @@ func Test_MetricDataToSignalFxV2(t *testing.T) {
 							Labels: map[string]string{
 								"k/r0":             "vr0",
 								"k/r1":             "vr1",
-								"cloud.provider":   "gce",
+								"cloud.provider":   cloudProviderGCP,
 								"cloud.account.id": "efgh",
 								"host.id":          "abcd",
 							},