Skip to content

Commit 94c9288

Browse files
[chore] unexport RunningContainer
1 parent 83443b7 commit 94c9288

File tree

2 files changed

+33
-6
lines changed

2 files changed

+33
-6
lines changed

.chloggen/unexport_struct2.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: k8sobserver
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Unexport RunningContainer
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [40228]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [api]

extension/observer/k8sobserver/pod_endpoint.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func convertPodToEndpoints(idNamespace string, pod *v1.Pod) []observer.Endpoint
3939
}}
4040

4141
// Map of running containers by name.
42-
runningContainers := map[string]RunningContainer{}
42+
runningContainers := map[string]runningContainer{}
4343

4444
for _, container := range pod.Status.ContainerStatuses {
4545
if container.State.Running != nil {
@@ -49,7 +49,7 @@ func convertPodToEndpoints(idNamespace string, pod *v1.Pod) []observer.Endpoint
4949

5050
// Create endpoint for each named container port.
5151
for _, container := range pod.Spec.Containers {
52-
var runningContainer RunningContainer
52+
var runningContainer runningContainer
5353
var ok bool
5454
if runningContainer, ok = runningContainers[container.Name]; !ok {
5555
continue
@@ -105,18 +105,18 @@ func getTransport(protocol v1.Protocol) observer.Transport {
105105
}
106106

107107
// containerIDWithRuntime parses the container ID to get the actual ID string
108-
func containerIDWithRuntime(c v1.ContainerStatus) RunningContainer {
108+
func containerIDWithRuntime(c v1.ContainerStatus) runningContainer {
109109
cID := c.ContainerID
110110
if cID != "" {
111111
parts := strings.Split(cID, "://")
112112
if len(parts) == 2 {
113-
return RunningContainer{parts[1], parts[0]}
113+
return runningContainer{parts[1], parts[0]}
114114
}
115115
}
116-
return RunningContainer{}
116+
return runningContainer{}
117117
}
118118

119-
type RunningContainer struct {
119+
type runningContainer struct {
120120
ID string
121121
Runtime string
122122
}

0 commit comments

Comments
 (0)