You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[receiver/googlecloudmonitoring] Add support for delta distributions (#40688)
#### Description
This adds support for converting Google Cloud monitoring delta
distribution metrics to OpenTelemetry histograms.
#### Link to tracking issue
This is related to
#39600,
although it might not be a complete solution, since this only
contributes delta distributions, but not cumulative distributions.
#### Testing
This has been tested extensively with the metric
`run.googleapis.com/request_latencies`.
Here is a comparison of the p95 of that metric directly in Google Cloud
and of the OTel metric as produced by the new code in a third party tool
(Dash0).
<img width="1742" alt="20250612_request_latencies_comparison"
src="https://github.com/user-attachments/assets/dd88d338-3abd-4dfb-a969-72af7c345a5c"
/>
There charts have minor differences which I suspect are introduced by
different interpolation strategies in the two tools (we only have one
datapoint per minute), but besides that, the charts clearly show the
same data -- peaks and valleys are at the same timestamps and the y-axis
values also match.
There are also comprehensive unit tests for the new functionality in
`receiver/googlecloudmonitoringreceiver/internal/metrics_conversion_test.go`.
#### Remarks
Unfortunately I only saw #40216 after I had more or less finished my
implementation here. I realize that this is not ideal, since there are
now two different PRs that attempt to add the same feature. I am not
sure if the author of #40216 is still working on their PR actively. I
think the last status there seems to be that tests are missing. I'm
happy to port over changes from #40216 in case it has things that are
missing here or help porting over changes from here to #40216, if that
helps. That said, this PR has a full set of unit tests and it also has
support for converting the span context exemplar (although that
certainly needs to be double checked, see inline comments).
---------
Co-authored-by: Ben Blackmore <[email protected]>
0 commit comments