Skip to content

Commit cca6b87

Browse files
authored
[exporter/signalfx] Change default timeout to 10 seconds (#29436)
Change the default timeout from 5s to 10s Signed-off-by: Dani Louca <[email protected]>
1 parent a0e6491 commit cca6b87

File tree

4 files changed

+30
-3
lines changed

4 files changed

+30
-3
lines changed

.chloggen/sfx-http-timeout.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: enhancement
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: signalfxexporter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: change default timeout to 10 seconds
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [29436]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: []

exporter/signalfxexporter/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ The following configuration options can also be configured:
8484
- `disable_default_translation_rules` (default = `false`): Disable default translation
8585
of the OTel metrics to a SignalFx compatible format. The default translation rules are
8686
defined in `translation/constants.go`.
87-
- `timeout` (default = 5s): Amount of time to wait for a send operation to
87+
- `timeout` (default = 10s): Amount of time to wait for a send operation to
8888
complete.
8989
- `headers` (no default): Headers to pass in the payload.
9090
- `max_idle_conns` (default = 100): The maximum idle HTTP connections the client can keep open.

exporter/signalfxexporter/config_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func TestLoadConfig(t *testing.T) {
4848
AccessToken: "testToken",
4949
Realm: "ap0",
5050
HTTPClientSettings: confighttp.HTTPClientSettings{
51-
Timeout: 5 * time.Second,
51+
Timeout: 10 * time.Second,
5252
Headers: nil,
5353
MaxIdleConns: &hundred,
5454
MaxIdleConnsPerHost: &hundred,

exporter/signalfxexporter/factory.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
)
2323

2424
const (
25-
defaultHTTPTimeout = time.Second * 5
25+
defaultHTTPTimeout = time.Second * 10
2626
defaultMaxConns = 100
2727

2828
defaultDimMaxBuffered = 10000

0 commit comments

Comments
 (0)