Skip to content

Signalfx exporter: add translations for filesystem metrics #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dmitryax
Copy link
Member

No description provided.

@dmitryax dmitryax requested a review from a team July 30, 2020 17:42
@dmitryax dmitryax force-pushed the filesystem-metrics-sfx-translations branch from bb8ce78 to 6f1470a Compare July 30, 2020 18:31
@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #584 into master will increase coverage by 15.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #584       +/-   ##
===========================================
+ Coverage   71.09%   86.26%   +15.17%     
===========================================
  Files          14      195      +181     
  Lines         602    10632    +10030     
===========================================
+ Hits          428     9172     +8744     
- Misses        150     1128      +978     
- Partials       24      332      +308     
Flag Coverage Δ
#integration 71.09% <ø> (ø)
#unit 86.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/newrelicexporter/factory.go 68.42% <0.00%> (ø)
receiver/kubeletstatsreceiver/kubelet/metadata.go 100.00% <0.00%> (ø)
exporter/elasticexporter/factory.go 100.00% <0.00%> (ø)
exporter/sapmexporter/config.go 100.00% <0.00%> (ø)
exporter/sentryexporter/factory.go 88.88% <0.00%> (ø)
receiver/k8sclusterreceiver/watcher.go 79.26% <0.00%> (ø)
receiver/sapmreceiver/factory.go 100.00% <0.00%> (ø)
receiver/receivercreator/receiver.go 73.80% <0.00%> (ø)
exporter/jaegerthrifthttpexporter/exporter.go 60.46% <0.00%> (ø)
exporter/awsxrayexporter/translator/segment.go 92.40% <0.00%> (ø)
... and 176 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368adbd...6f1470a. Read the comment docs.

@bogdandrutu bogdandrutu merged commit 1322bef into open-telemetry:master Jul 31, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
1. Introduced data structures that represent telemetry data in-memory.

2. Renamed OTLP* interfaces and types to *V2 types to denote that they are
   Internal and not OTLP and are the new version of internal data.
   Internal representation is somewhat different from OTLP.

Testing done: unit tests that cover non-trivial functions. Single-line
getters and setters are typically not covered.

Documentation: added doc.go to describe the implementation and usage.

Design doc and benchmarks: https://docs.google.com/document/d/1MSKjMVXQsP51lA6OwpfyLfZhWK-MkGo5vff43LhrqZU/edit#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants