Skip to content

Commit 1a83c3b

Browse files
committed
feedback from code review
1 parent 200ecca commit 1a83c3b

File tree

3 files changed

+11
-14
lines changed

3 files changed

+11
-14
lines changed

service/hostcapabilities/go.mod

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@ module go.opentelemetry.io/collector/service/hostcapabilities
22

33
go 1.23.0
44

5-
require go.opentelemetry.io/collector/service v0.119.0
5+
require (
6+
go.opentelemetry.io/collector/component v0.119.0
7+
go.opentelemetry.io/collector/pipeline v0.119.0
8+
go.opentelemetry.io/collector/service v0.119.0
9+
)
610

711
require (
812
github.com/gogo/protobuf v1.3.2 // indirect
9-
go.opentelemetry.io/collector/component v0.119.0 // indirect
1013
go.opentelemetry.io/collector/pdata v1.25.0 // indirect
1114
go.opentelemetry.io/otel v1.34.0 // indirect
1215
go.opentelemetry.io/otel/metric v1.34.0 // indirect

service/hostcapabilities/interfaces.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
package hostcapabilities // import "go.opentelemetry.io/collector/service/hostcapabilities"
77

88
import (
9+
"go.opentelemetry.io/collector/component"
10+
"go.opentelemetry.io/collector/pipeline"
911
"go.opentelemetry.io/collector/service/internal/moduleinfo"
1012
)
1113

@@ -15,4 +17,8 @@ type ModuleInfo interface {
1517
// GetModuleInfos returns the module information for the host
1618
// i.e. Receivers, Processors, Exporters, Extensions, and Connectors
1719
GetModuleInfos() moduleinfo.ModuleInfos
20+
21+
// TODO: remove as part of https://github.com/open-telemetry/opentelemetry-collector/issues/7370 for service 1.0
22+
// Deprecated: [v0.120.0] Will be removed in Service 1.0.
23+
GetExporters() map[pipeline.Signal]map[component.ID]component.Component
1824
}

service/internal/graph/host.go

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,8 @@ import (
2121
"go.opentelemetry.io/collector/service/internal/zpages"
2222
)
2323

24-
// TODO: remove as part of https://github.com/open-telemetry/opentelemetry-collector/issues/7370 for service 1.0
25-
type getExporters interface {
26-
GetExporters() map[pipeline.Signal]map[component.ID]component.Component
27-
}
28-
29-
type getModuleInfos interface {
30-
// GetModuleInfo returns the module information for the host.
31-
GetModuleInfos() moduleinfo.ModuleInfos
32-
}
33-
3424
var (
35-
_ getExporters = (*Host)(nil)
3625
_ component.Host = (*Host)(nil)
37-
_ getModuleInfos = (*Host)(nil)
3826
_ hostcapabilities.ModuleInfo = (*Host)(nil)
3927
)
4028

0 commit comments

Comments
 (0)