reduce allocations

Author: dmathieu

pdata/pprofile/attributes.go

@@ -13,15 +13,38 @@ type attributable interface {
 
 // BuildAttributes builds a [pcommon.Map] containing the attributes of a record.
 // The record can by any struct that implements an `AttributeIndices` method.
-func BuildAttributes(profile Profile, record attributable) (pcommon.Map, error) {
-	attrs := map[string]any{}
+func BuildAttributes(profile Profile, record attributable) pcommon.Map {
+	m := pcommon.NewMap()
+
+	for i := 0; i < record.AttributeIndices().Len(); i++ {
+		id := int(record.AttributeIndices().At(i))
+		a := profile.AttributeTable().At(id)
 
-	for i := range record.AttributeIndices().AsRaw() {
-		a := profile.AttributeTable().At(i)
-		attrs[a.Key()] = a.Value().AsRaw()
+		key := a.Key()
+		val := a.Value()
+
+		switch val.Type() {
+		case pcommon.ValueTypeEmpty:
+			m.PutStr(key, "")
+		case pcommon.ValueTypeStr:
+			m.PutStr(key, val.AsString())
+		case pcommon.ValueTypeBool:
+			m.PutBool(key, val.Bool())
+		case pcommon.ValueTypeDouble:
+			m.PutDouble(key, val.Double())
+		case pcommon.ValueTypeInt:
+			m.PutInt(key, val.Int())
+		case pcommon.ValueTypeBytes:
+			bs := m.PutEmptyBytes(key)
+			val.Bytes().CopyTo(bs)
+		case pcommon.ValueTypeMap:
+			ma := m.PutEmptyMap(key)
+			val.Map().CopyTo(ma)
+		case pcommon.ValueTypeSlice:
+			sl := m.PutEmptySlice(key)
+			val.Slice().CopyTo(sl)
+		}
 	}
 
-	m := pcommon.NewMap()
-	err := m.FromRaw(attrs)
-	return m, err
+	return m
 }

pdata/pprofile/attributes_test.go

@@ -22,27 +22,24 @@ func TestBuildAttributes(t *testing.T) {
 	att2.SetKey("bonjour")
 	att2.Value().SetStr("monde")
 
-	attrs, err := BuildAttributes(profile, profile)
-	require.NoError(t, err)
+	attrs := BuildAttributes(profile, profile)
 	assert.Equal(t, attrs, pcommon.NewMap())
 
 	// A Location with a single attribute
 	loc := NewLocation()
-	loc.AttributeIndices().Append(1)
+	loc.AttributeIndices().Append(0)
 
-	attrs, err = BuildAttributes(profile, loc)
-	require.NoError(t, err)
+	attrs = BuildAttributes(profile, loc)
 
 	m := pcommon.NewMap()
 	require.NoError(t, m.FromRaw(map[string]any{"hello": "world"}))
 	assert.Equal(t, attrs, m)
 
 	// A Mapping with two attributes
 	mapp := NewLocation()
-	mapp.AttributeIndices().Append(1, 2)
+	mapp.AttributeIndices().Append(0, 1)
 
-	attrs, err = BuildAttributes(profile, mapp)
-	require.NoError(t, err)
+	attrs = BuildAttributes(profile, mapp)
 
 	m = pcommon.NewMap()
 	require.NoError(t, m.FromRaw(map[string]any{"hello": "world", "bonjour": "monde"}))
@@ -65,6 +62,6 @@ func BenchmarkBuildAttributes(b *testing.B) {
 	b.ReportAllocs()
 
 	for n := 0; n < b.N; n++ {
-		_, _ = BuildAttributes(profile, obj)
+		_ = BuildAttributes(profile, obj)
 	}
 }